Non static variable cannot be referenced

Question

I'm trying to make the code in my main() method as light as possible by dividing the code in multiple function, so for example I create an instance of a class RentalAgency with the following function :

/** Creates an Agency with some cars and motorbikes
  */
  public RentalAgency createAgency(){
    List<Vehicle> theVehicles = new ArrayList<Vehicle>();
    Map<Client,Vehicle> rentedVehicles = new HashMap <Client,Vehicle>();
    RentalAgency agency = new RentalAgency(theVehicles, rentedVehicles);
    Vehicle v1 = new Vehicle("Renault","clio",1998,50);
    agency.addVehicle(v1);
    Vehicle v2 = new Vehicle("Renault","twingo",2000,40);
    agency.addVehicle(v2);
    Car c1 = new Car("Renault","scenic",2005, 80, 7);
    agency.addVehicle(c1);
    Car c2 = new Car("Citroen","c3",2006, 70, 5);
    agency.addVehicle(c2);
    MotorBike m1 = new MotorBike("Honda","CB",2015, 50, 500);
    agency.addVehicle(m1);
    MotorBike m2 = new MotorBike("Yamaha","MT",2017, 80, 750);
    agency.addVehicle(m2);
    return agency;
  }

And in the main() I try to run this :

/**The main function to run the Agency and some renting
  */
    public static void main(String[] args) throws UnknownVehicleException {
      RentalAgency agency = this.createAgency();
    }

but I get an error like so :

error: non-static variable this cannot be referenced from a static context RentalAgency agency = this.createAgency();

Which I don't really know how to correct, I looked it up and it seems to occurs when you try to use a method on something that is not initiated ?

Md Johirul Islam · Answer 1 · 2018-04-09T21:25:03.023

3

Change the method signature to following:

public static RentalAgency createAgency() {...}

You also need to remove this referencing from the main() method and simply call the method in the following way:

RentalAgency agency = createAgency();

edited Apr 09 '18 at 21:25

answered Apr 09 '18 at 21:15

Md Johirul Islam

5,042
4
23
56

I'm not sure as to how is adding static to the declaration helping ? – Rémy.W Apr 09 '18 at 21:17
You can't call a non-static method inside static `main()` method – Md Johirul Islam Apr 09 '18 at 21:18
1

in addition to adding static, you need to remove this from main method. – humblefoolish Apr 09 '18 at 21:22

humblefoolish · Accepted Answer · 2018-04-09T21:24:28.450

1

this in java refers to the object which you have in hand. Now, in your case there is no object just the reference of RentalAgency in main method.

To use this, you need to create an object. But, I am guessing you are using createAgency method for that instead of the usual constructor approach. So, mark the createAgency as static and call it without using this from main method.

public static RentalAgency createAgency(){
   //Some code goes here
}

public static void main(String[] args) throws UnknownVehicleException 
{
  RentalAgency agency = createAgency();
}

edited Apr 09 '18 at 21:24

answered Apr 09 '18 at 21:15

humblefoolish

409
3
15

Works like a charm, thanks ! :) – Rémy.W Apr 09 '18 at 21:24
happy to help. If it helped, please accept the answer. :) – humblefoolish Apr 09 '18 at 21:25
"this in java refers to the object which you have in hand"... Eh, kind'a... But there's still things like `OuterClass.this` from an inner class where this doesn't really ring true. – BeUndead Apr 09 '18 at 21:35

score 0 · Answer 3 · answered Apr 09 '18 at 21:16

0

main() is a static function, so there is no instance this to be referenced from within. Try making createAgency() static:

public static RentalAgency createAgency() {
    ...
}

answered Apr 09 '18 at 21:16

Jason Carlson

398
2
4

Non static variable cannot be referenced

3 Answers3