Setting the name of a variable in an ArrayList equal to the value of a certain String in Java

Question

I am making a while loop that asks for a name and an id and adds it to an ArrayList repeatedly until told to stop for my computer science class. How could I get the name of the new "TeamMember" to change every time? Also, would that even work and if not why and how could I get it to work? This is my code (Main):

import java.util.ArrayList;
import java.util.Scanner;

public class TeamClassMain {

public static void main(String[] args) {

    Scanner scan = new Scanner(System.in);
    ArrayList <TeamMember> list = new ArrayList();
    String name;
    String id;
    String ArrayVar;
    int number = 0;
    int stop = 0;
    while (stop == 0) {
        System.out.println("Enter the next name:");
        name = scan.nextLine();
        name = name.toLowerCase();
        if (name == "stop") {
            stop = 1;
        }
        System.out.println("Enter the next ID:");
        id = scan.nextLine();
        ArrayVar = "member " + number;
        TeamMember member1 = new TeamMember(name, id);
        number++;
        }
   }  
}

This isn't necessary, but it might be interesting to know what TeamMember is so this is my TeamMember class:

import java.lang.*;

public class TeamMember {

String fullName;
String idString;

TeamMember(String name, String id) {
    name = name.toUpperCase();
    char character;
    String string;
    int num;
    for (int i = 0; i < name.length() - 1; i++) {
        if (i == 0) {
             character = name.charAt(0);
             string = "" + character;
             string = string.toUpperCase();
             character = string.charAt(0); 
             i = character;
        }
        if (name.charAt(i) == ' ') {
            character = name.charAt(i + 1);
            string = "" + character;
            string = string.toUpperCase();
            character = string.charAt(i + 1);
            name.substring(i + 1, character);
        }
    }
    fullName = name;
    idString.valueOf(id);
}

public String toString() {
    return fullName;    
}

int compareTo(TeamMember other) {
    return idString.compareTo(other.idString);
    }
}

See: [How do I compare strings in Java?](https://stackoverflow.com/q/513832/5221149) — Andreas, Apr 13 '18 at 16:24
you never actually add your TeamMember to your arraylist called list — RAZ_Muh_Taz, Apr 13 '18 at 16:26
You do create new `TeamMember` with the `name` you got from the input. So, what's the problem? I fail to understand what are you asking. — lexicore, Apr 13 '18 at 16:26
What is purpose of `ArrayVar`? You never use it. --- What is logic in `TeamMember` constructor supposed to do? `name.substring(i + 1, character)` does nothing, since you never assign returned values anywhere. And `i = character`? Do you understand what assign `char` value to `int` value does? — Andreas, Apr 13 '18 at 16:27
@Turing85 member1. I now understand that what I asked is irrelevant — Aidan, Apr 13 '18 at 16:33

score 0 · Answer 1 · edited Apr 13 '18 at 16:33

0

you need to add TeamMember to ArrayList

TeamMember member1 = new TeamMember(name, id);
list.add(member1);//add to list

you should break the while loop after stop that stop not gonna add in list and use equal for comparing the string

if (name.equals("stop")) {
    stop = 1;
    break;
}

edited Apr 13 '18 at 16:33

Turing85

18,217
7
33
58

answered Apr 13 '18 at 16:26

Roushan

4,074
3
21
38

I understand that, but wouldn't I need to change the name of the TeamMember every time? – Aidan Apr 13 '18 at 16:27
@Aidan Why would you need to *change* the name? Wouldn't the next name be assigned to a *different* (new) team member? – Andreas Apr 13 '18 at 16:28
I believe you are correct. I think my problem is somewhere else. Thanks for the help – Aidan Apr 13 '18 at 16:29
@Aidan Oh, I sure the have problems elsewhere, because your code is riddled with errors. – Andreas Apr 13 '18 at 16:30
In main or in TeamMember? – Aidan Apr 13 '18 at 16:30
Or are there problems with both? – Aidan Apr 13 '18 at 16:31
@Aidan Yes. Both. – Andreas Apr 13 '18 at 16:31
@Andreas So should I use .equals("")? – Aidan Apr 13 '18 at 16:31

score 0 · Accepted Answer · answered Apr 13 '18 at 16:33

Step 1 - Don't use a hammer to drive screws. Specifically, pay attention to the input data: you are asking the user to enter a map value between a name and an id. It appears that the name is the key and the id is the value. Store map "stuff" in a Map.

Step 2 - The TeamMember class provides just about 0 value. Just use the map between name and id.

In a less toy problem, TeamMember would do more that map between name and id. In that case, determine which is the appropriate key (id or name) and allocate (use new) a new TeamMember as the value each time you insert into the Map.

Thank you. I believe I understand what you mean. – Aidan Apr 13 '18 at 16:36 — Aidan, Apr 13 '18 at 16:36

Setting the name of a variable in an ArrayList equal to the value of a certain String in Java

2 Answers2