PHP count() counts text array as single element

Question

I am running PHP 7.0.22, under LAMP, on two ubuntu 16.04.

My PHP code is as follows

    $str="ls -1 /var/www/dropbox | egrep '*.CEL|*.cel'";
    $result= explode(PHP_EOL, shell_exec($str));
    $fileNames=$result;
    print_r($fileNames);
    echo "<br>";
    $inputFileCount=count($fileNames,1);
    echo "<br>";
    echo "File count:" . print_r($inputFileCount);
    echo "<br>";

I get the following on the screen

Array ( [0] => prefix1.cel [1] => prefix12.cel [2] => ) 

File count:1

It seems to me that the count should be 2.

Use `glob()` to get an array of files. You're getting empty values. http://php.net/manual/en/function.glob.php. — Pedro Lobito, Apr 15 '18 at 00:34
Considering your array has three items, I'd expect the count to be 3 not 2. — Progrock, Apr 15 '18 at 09:13

Pedro Lobito · Accepted Answer · 2018-04-15T01:00:47.717

4

Use glob() to get a list of .cel files, i.e.:

$files = glob("/var/www/dropbox/*.cel");
echo count($files)

To loop use:

foreach ($files as $filename) {
    echo "$filename size " . filesize($filename) . "\n";
}

edited Apr 15 '18 at 01:00

answered Apr 15 '18 at 00:46

Pedro Lobito

94,083
31
258
268

1

That works! I modified it to "$files = glob("/var/www/dropbox/*.[cC][eE][lL]");" to make it case insensitive. Thanks very much, – OtagoHarbour Apr 15 '18 at 01:00
1

Awesome! You're very welcome @OtagoHarbour, glad it worked! – Pedro Lobito Apr 15 '18 at 01:01

score 1 · Answer 2 · answered Apr 15 '18 at 01:06

You could also use PHP SPL Iterator classes.

<?php
$folder = '/var/www/dropbox';

// define filtering (match only .cel or .CEL files)
$filter = new \RecursiveCallbackFilterIterator(
    new \RecursiveDirectoryIterator($folder, \FilesystemIterator::SKIP_DOTS), 
    function ($current, $key, $iterator) {
        return strtolower($current->getExtension()) === 'cel';
    }
);

$iterator = new \RecursiveIteratorIterator($filter);

// get count
echo iterator_count($iterator);

// loop over
if (iterator_count($iterator) > 0) {
    foreach ($iterator as $file) {
        echo $file;
    }
}

Slightly more code then glob, but also an option.

score 1 · Answer 3 · answered Apr 15 '18 at 01:16

1

ls -l gives you the long listing showing size, permissions, etc. I don't think this is what you want.

Use "\n" as the splitting parameter to split on new lines.

After explode() you want to work with the created array.

One more thing: Please use echo in your code. print_r is for outputting more info about a variable.

$str="ls /var/www/dropbox | egrep '*.CEL|*.cel'";
$result= explode("\n", $str);

foreach($result as $filename) {
    echo $filename . "<br />";
}

$inputFileCount = count($result);
echo "<br>";
echo "File count:" . $inputFileCount;
echo "<br>";

answered Apr 15 '18 at 01:16

Greg Klaus

109
5

1

Think it's `-1`. – Progrock Apr 15 '18 at 01:20
1

Test the code before down voting. `count()` counts elements in an array, if the array is created properly. And, in this case, it is. – Greg Klaus Apr 15 '18 at 01:31
I don't see any down votes. I was referring to the `ls` switch. – Progrock Apr 15 '18 at 09:11
My apologies! I misread that as a potential down vote! – Greg Klaus Apr 15 '18 at 09:34
`ls` will give you just the file names. `ls - l` gives the long listing. My assumption was that from the OP's original output the only output was the filename. – Greg Klaus Apr 15 '18 at 09:36
`ls - l` likely won't give you much! I should have been more explicit, OP is calling ls with the switch for single-column formatting. – Progrock Apr 15 '18 at 09:53

PHP count() counts text array as single element

3 Answers3