2

The things are little complicated, let me show you a minimal example.

In my app, I dynamic import a Class from django settings:

 my_settings.py     

 from django.conf import settings

 SETTINGS = getattr(settings, 'ACTSTREAM_SETTINGS', {})

 def get_verb_transformer():
     mod = SETTINGS.get('VERB_TRANSFORMER', 'actstream.transformers.DefaultVerbTransformer')
     mod_path = mod.split('.')
     try:
         return getattr(__import__('.'.join(mod_path[:-1]), {}, {},
                                  [mod_path[-1]]), mod_path[-1])()
     except ImportError:
         raise ImportError(
            'Cannot import %s try fixing ACTSTREAM_SETTINGS[VERB_TRANSFORMER]'
            'setting.' % mod
         )

get_verb_transformer just import the class based on the value of VERB_TRANSFORMER from django.conf.settings。Thus,we allow developers to specify their own custom VerbTransformer class. Or if they don't provide one, build-in DefaultVerbTransformer as a fallback.

Then I used the imported class in other places:

from . import my_settings

def follow(user, obj, send_action=True, actor_only=True, flag='', **kwargs):
     instance, created = apps.get_model('actstream', 'follow').objects.get_or_create(
         user=user, object_id=obj.pk, flag=flag,
         content_type=ContentType.objects.get_for_model(obj),
         actor_only=actor_only
     )
     if send_action and created:
         if not flag:
             action.send(user, verb=_('started following'), target=obj, **kwargs)
         else:
             action.send(user, verb=_('started %s' % flag), target=obj, **kwargs)        

             ########### used here ###########
             transformer = settings.get_verb_transformer()
             action.send(user, verb=_('started %s' % transformer.trans(flag)), target=obj, **kwargs)
     return instance

Then I want to test developer custom setting does work:

    @override_settings(ACTSTREAM_SETTINGS={'VERB_TRANSFORMER': 
 'actstream.tests.base.TestVerbTransformer'})
     def test_follow_verb_transformation(self):
         # User4 blocks user3
         follow(self.user4, self.another_user, timestamp=self.testdate, flag='block')
         # User4 quits group
         follow(self.user4, self.another_comment, timestamp=self.testdate, flag='quit')

However, in unittest, follow function still use DefaultVerbTransformer instead of override setting TestVerbTransformer

What's the problem here?

You Gakukou
  • 643
  • 7
  • 16

0 Answers0