1

I am new to Dagger. I have a confusion about what to and what not to inject with dagger. I know that it is necessary to inject Android Framework classes and my classes using Dagger but is it really necessary to inject even basic Java classes like String, StringBuilder etc using dagger or not.

 public String create(Context context) // Creating Simple objects in the method itself
{
 StringBuilder builder=new StringBuilder();
    ....
   return builder.toString();
}


public String create(Context context,StringBuilder builder) // Injecting everything
 {
....
return builder.toString();
}
Mohammed Daoud
  • 202
  • 1
  • 10
  • This is quite a similar question to https://stackoverflow.com/questions/44046573/is-inject-everything-a-bad-practice-in-android?rq=1 – David Rawson Apr 21 '18 at 03:57

2 Answers2

2

You don't have to inject anything. You can create anything you like in the method. Inside the method is just plain old Java code.

Only inject something as a parameter when the thing you are creating in that method doesn't care about the specific value, but just needs a value.

The thing about injecting common classes is that you need to qualify them: this String you are injecting here isn't necessarily the same as that String you are injecting there. So you need some way to disambiguate them, such as annotations.

But if you are injecting everything as a matter of course, you will end up with an awful lot of annotations. Sometimes you do want to do this; sometimes not. It's something you get a feel of as you write more code.

Andy Turner
  • 137,514
  • 11
  • 162
  • 243
0

Put a different way, the important part of injection is that it lets you manage the state of your objects (including lifecycle, if you want that).

So if you have a class with no state (e.g. a Util class that provides some stateless functions), you should never inject that.

If your StringBuilder class doesn't need to share state (i.e. use the same StringBuilder across two objects), then you don't need to inject it.

trapezoid
  • 101
  • 1
  • 3