Value changed to null in ajax

Question

Value changed to null in ajax after updating the shipping city value from text field. I don't known what is the problem.. please help me Friends.

my php code:

 public function updateshippingcity() {

  if ($this->request->server['REQUEST_METHOD'] == 'POST') 
   {
      $json['new_shipping_city'] = $this->request->post['shipping_city'];


     $this->db->query("UPDATE " . DB_PREFIX . "order SET shipping_city = '" . $this->db->escape($this->request->post['shipping_city']) . "' WHERE order_id = '" . (int)$this->request->get['order_id'] . "'");


     $this->response->setOutput(json_encode($json));
  }

}

my ajax code :

<script type="text/javascript">
$("#update-shipping-city").click(function() {
    var name_val = $('input[name="new_shipping_city"]').val();
    $.ajax({
        url: 'index.php?route=sale/order/updateshippingcity&token=<?php echo $token; ?>&order_id=<?php echo $order_id; ?>',
        type: 'post',
        dataType: 'json',
        data: {
            shipping_city: name_val
        },
        beforeSend: function() {
            $('#update-shipping-city').attr('disabled', true);
        },
        complete: function() {
            $('#update-shipping-city').attr('disabled', false);
        },
        success: function(json) {

        }
    });
    alert("shipping city has changed");
});

my html code:

<div class="col-md-12">
    <input  name="new_shipping_city" value="<?php echo $shipping_city; ?>"></input>
    <button id="update-shipping-city" > update </button>
</div>

Your script is wide open to [SQL Injection Attack](http://stackoverflow.com/questions/60174/how-can-i-prevent-sql-injection-in-php) Even [if you are escaping inputs, its not safe!](http://stackoverflow.com/questions/5741187/sql-injection-that-gets-around-mysql-real-escape-string) Use [prepared parameterized statements](http://php.net/manual/en/mysqli.quickstart.prepared-statements.php) in either the `MYSQLI_` or `PDO` API's — RiggsFolly, Apr 20 '18 at 15:38
@RiggsFolly its only visible in admin dashboards. not in public website. anyway thanks for the information :) — Ask Xah, Apr 20 '18 at 15:40
Visible to admins only or not, you should always follow best security practices when developing an application. Using prepared statements in an application is not a very hard thing to do. — Taplar, Apr 20 '18 at 15:42
@RiggsFolly that tag only for clicking usage.. i need to change the value of the $shipping_city through ajax. that i tried here.. but after updating ajax sends null value to db :( — Ask Xah, Apr 20 '18 at 15:42
And WHY after doing an AJAX call to get data from the server are you then reloading the page?? Totally negating the point of the AJAX call ??? — RiggsFolly, Apr 20 '18 at 15:43
I thought what RiggsFolly was questioning with that echo, was that you were echoing a static string, not a variable. So it could have just been in the markup without the echo. — Taplar, Apr 20 '18 at 15:44
RiggsFolly linked the prepared statements link in his one comment at the end — Taplar, Apr 20 '18 at 15:44
@RiggsFolly I'm used reloading for page refresh. is that not required? — Ask Xah, Apr 20 '18 at 15:45
The main point of AJAX is to amend the page dynamically without having to refresh the page — RiggsFolly, Apr 20 '18 at 15:50
@RiggsFolly i'm a beginner thanks for the information. Now i need the solution for my problem :( — Ask Xah, Apr 20 '18 at 15:52
You ahve not given us enough code. Expand the `my html code:` code so we can see what happens when the page gets reloaded. That is where it should be picking up the chnaged database so we need to see what is going on in there — RiggsFolly, Apr 20 '18 at 16:27
I had updated my question, i want to update the $shipping_city after clicking the update button in ajax — Ask Xah, Apr 20 '18 at 17:06
when you inspect the input element before submitting the button does it show you the correct value? — Amr Aly, Apr 20 '18 at 17:53
there no data is printed in php so how value will be returned — jasinth premkumar, Apr 20 '18 at 17:58

score 0 · Accepted Answer · answered Apr 20 '18 at 19:00

I had achieved finally by post method.

<script type="text/javascript">
$(function() {
    $("#update-shipping-city").click(function(e) {
        e.preventDefault();
        var scity_val = $('input[name="new_shipping_city"]').val();
        $.post("index.php?route=sale/order/updateshippingcity&token=<?php echo $token; ?>&order_id=<?php echo $order_id; ?>", {
            shipping_city: scity_val
        }, function(data, status) {
            alert("Data: " + data + "\nStatus: " + status);
        });
    });
});

Finally, my problem cleared. thank guys for contributing on my question :)

Value changed to null in ajax

1 Answers1