How do I display a Toast in a setOnClickListener?

Question

I'm trying to show a Toast when the user clicks on the Play button. But makeText is red in my code, and it won't run. Where am I turning wrong?

Here is the Java code:

    // Find the View that shows the play_a button
    ImageView play_a = findViewById(R.id.play_a);

    // Set a click listener on that View
    play_a.setOnClickListener(new View.OnClickListener() {
        // The code in this method will be executed when play_a is clicked on.
        Toast.makeText(this, "Sorry, Play doesn't work", Toast.LENGTH_LONG).show();
    });

Is the problem that I need to override setOnClickListener?

Possible duplicate of [Android, using Toast inside onClickListener](https://stackoverflow.com/questions/40437997/android-using-toast-inside-onclicklistener) — Lucas Cabrales, Apr 20 '18 at 21:52

score 2 · Answer 1 · answered Apr 20 '18 at 21:52

2

this keyword in makeText refers to anonymous-inner-class of type OnClickListener. You need to change it to pass the Context.

For example: play_a.getContext() or the way you like to refer.

answered Apr 20 '18 at 21:52

waqaslam

67,549
16
165
178

Where do I put `play_a.getContext()`? – davidtspf Apr 20 '18 at 21:58
It's just an example of passing the context reference by using the View. You can even use `getBaseContext()` – waqaslam Apr 20 '18 at 22:00
Replace `this` in makeText with the suggestion – waqaslam Apr 20 '18 at 22:00

score 1 · Accepted Answer · answered Apr 20 '18 at 21:56

You have to override the onClick function.

play_a.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            Toast.makeText(getApplicationContext(),"Sorry, Play doesn't work", Toast.LENGTH_LONG).show();
        }
    });

How do I display a Toast in a setOnClickListener?

2 Answers2