joining two javascript code as one single code separators

Question

I need to create a re-useable function. The following script should prevent form submit and show a div alert. This version does not prevent form submit

<script type="text/javascript">
    function hide(obj) {
        var el = document.getElementById(obj);
        el.style.display = 'none';
    }
    $(function() {
        $('form#vendiendo').submit(function(e) {
            if (Number($("#venta").val()) <
                Number($("#costo").val())) {
                $("#warnings").show();

                //here start  the new code I added
                if (Number($("#cantidad").val()) >
                    Number($("#stock").val())) {
                    $("#warnings2").show();

                    //here ends the new code I added
                    return false;
                }
            });
        });
</script>

Use an editor that indents the code so you can see the structure, it will help you program correctly. — Barmar, Apr 21 '18 at 14:51
returning false from your function won't stop form submit, it will only return false, which you then aren't handling. Instead, take a look at my answer -- if the validation has failed, stop the event itself. — Snowmonkey, Apr 21 '18 at 15:11

score 0 · Answer 1 · answered Apr 21 '18 at 15:10

If you want to stop the form from submitting in the case of an error, this should do.

<script type="text/javascript">
function hide(obj) {
    var el = document.getElementById(obj);
    el.style.display = 'none';
}
$(function() {
  $('form#vendiendo').submit(function(e) {
    if(Number($("#venta").val()) < Number($("#costo").val())) {
      $("#warnings").show();
      // You're still in the first if() statement. Is that what you want?
      if (Number($("#cantidad").val()) > Number($("#stock").val())) {
        // At this point, both checks have failed. We want to stop the
        // default behavior.
        e.preventDefault();
        e.stopPropagation();

        // And tell the user why we failed.
        $("#warnings2").show();

        return false;
      }
    });
  });
</script>

Do you have this on a server somewhere where we can see the HTML going with this? — Snowmonkey, Apr 21 '18 at 16:11
Also, this might help: take a look at https://stackoverflow.com/questions/22363838/submit-form-after-calling-e-preventdefault — Snowmonkey, Apr 21 '18 at 16:12

joining two javascript code as one single code separators

1 Answers1