I cannot save changes in xml PowerShell

Question

I need to update one line in xml and save changes. It looks ease but it doesn't work for me and I cannot find my mistake ( So, I need help. It is my code:

[xml]$XmlDocument = Get-Content -Path "C:\Users\Administrator\Documents\Practise\Test.xml"
$random = -join ((48..57) + (97..122) | Get-Random -Count 16 | % {[char]$_})

$node = $XmlDocument.Payment.PaymentOptions.Bank.Value5
$node = $node.Replace('13384wL839', $random)

$XmlDocument.Save("C:\Users\Administrator\Documents\Practise\Test.xml")

there is my xml:

<Payment xmlns="2.0.0">
  <PaymentValue1>
    <value1>180.00</value1>
    <value2>2017-09-30</value2>
    <value3>022456789</value3>
  </PaymentValue1>
  <PaymentOptions>
    <Bank>
      <Value4>Test1</Value4>
      <Value5>13384wL839</Value5>
    </Bank>
  </PaymentOptions>
</Payment>

I see that $node is changed but when I save new xml - it is still old value is displayed.

score 1 · Answer 1 · answered Apr 22 '18 at 18:41

Since the new value isn't related to the old one,
there is no need to replace anything,
you simply set the value.

$File= "C:\Users\Administrator\Documents\Practise\Test.xml"
[xml]$XmlDocument = Get-Content $File
$random = -join ((48..57) + (97..122) | Get-Random -Count 16 | % {[char]$_})

$XmlDocument.Payment.PaymentOptions.Bank.Value5 = $random

$XmlDocument.Save($File)

BlythMeister · Answer 2 · 2018-04-22T20:21:53.687

0

You are never actually setting the value back into the document.

$XmlDocument.Payment.PaymentOptions.Bank.Value5 = $XmlDocument.Payment.PaymentOptions.Bank.Value5.Replace('13384wL839', $random)

Should do the trick.

edited Apr 22 '18 at 20:21

answered Apr 22 '18 at 18:17

BlythMeister

299
1
12

I also tried to save value in new document. In this way new docuement is created but value doesn't update. $XmlDocument.Payment.PaymentOptions.Bank.Value5 = $XmlDocument.Payment.PaymentOptions.Bank.Value5.Replace('13384wL839', $random) -- it doesn't help. Value is changed but xml does not updated – Alice Savuliak Apr 22 '18 at 18:23
Updated answer, there was an error. From https://blogs.msdn.microsoft.com/sonam_rastogi_blogs/2014/05/14/update-xml-file-using-powershell/ – BlythMeister Apr 22 '18 at 18:27
As I see current node doesn't have such properties as "Value", so replace doesn't work – Alice Savuliak Apr 22 '18 at 18:46
Edited again, I think this is a duplicate though, so flagged accordingly – BlythMeister Apr 22 '18 at 18:50
I'd already tried 'InnerText' property, it also didn't help – Alice Savuliak Apr 22 '18 at 18:58
Have you checked the post I flagged this as a duplicate to? – BlythMeister Apr 22 '18 at 18:59
Yes, it doesn't work for me ( – Alice Savuliak Apr 22 '18 at 19:11
1

$XmlDocument.Payment.PaymentOptions.Bank.Value5 = $XmlDocument.Payment.PaymentOptions.Bank.Value5.Replace('13384wL839', $random) -- I made a mistake when tried this one. but I try again and it works! Thank you for help =) – Alice Savuliak Apr 22 '18 at 20:09
@AliceSavuliak glad it worked. I reverted this back to the original answer now, feel free to mark as accepted – BlythMeister Apr 22 '18 at 20:23

I cannot save changes in xml PowerShell

2 Answers2