Can I put multiple value in a OR condition?

Question

I have three roles in my app: admin, dev, and client. In my header, dev can access the same tabs as admin.

I tried this:

li = link_to 'Mon compte', client_edit_infos_path unless current_client.role == 'admin' || 'dev'

It worked for admin and dev roles, but not for client role.

Can someone tell me another way to authorize two roles and restrict one?

It should be either `current_client.role == 'admin'` or `current_client.role == 'dev'` so `current_client.role == 'admin' || current_client.role == 'dev'` — Sebastián Palma, Apr 23 '18 at 13:08
Better, create respective methods to your model: `admin?`, `admin_or_dev?` etc.. — yzalavin, Apr 23 '18 at 13:10

score 1 · Answer 1 · answered Apr 23 '18 at 13:09

1

%w(admin dev).include?(current_client.role)

answered Apr 23 '18 at 13:09

andriy-baran

620
4
16

I agree that this is the *Ruby way* of doing it, but I've always thought it's kind of backwards. – DarkWiiPlayer Apr 23 '18 at 13:32

score 1 · Answer 2 · answered Apr 23 '18 at 13:15

Please use an authorization gem, such as: https://github.com/CanCanCommunity/cancancan

Doing it manually is error prone and not easy to maintain.

You'll just need to define your ability:

and then in your code:

<% if can? :update, @client_info %>
  <%= link_to "Mon compte", client_edit_infos_path %>
<% end %>

Also, don't forget to set the same restriction in your controller actions! otherwise a user can bypass your view and trigger your action manually and have access to something they shouldn't.

score 0 · Answer 3 · answered Apr 23 '18 at 14:08

For an actual solution I recommend one of the other answers, but here's how it could work the way you originally intended (aka. what went wrong).

The problem is the condition at the end of the line: unless current_client.role == 'admin' || 'dev'

What ruby does here is not what you think; 'admin' || 'dev' is evaluated as 'admin', so the entire condition is equivalent to unless current_client.role == 'admin'.

The way the || operator works is:

If the first operand is truthy, it is the result of the operation.
If the first operand is falsey, the second operand is the result of the operation.

For example, true || false evaluates to true, 'hello' || 'world' is 'hello' and nil || 'world' evaluates to 'world'.

The correct condition would be unless current_client.role == 'admin' or current_client.role == 'dev'

or does the same as ||, but with higher precedence.

Can I put multiple value in a OR condition?

3 Answers3