What is the proper way to check an empty queryset in Django?

Question

queryset = demo.objects.filter(name="non_existent_name")

if queryset.exists():
    serializer = DemoSerializer(queryset, many=True)
    return Response(serializer.data)
else:
    return Response(status=status.HTTP_404_NOT_FOUND)

With an empty queryset - I am expecting a 404, but instead get a 200 with an empty serialized Response. What is wrong with my code? Why does exists() not work as expected?

if queryset.exists(): is returning True with an empty queryset — david, Apr 24 '18 at 16:39
Possible duplicate to: https://stackoverflow.com/questions/1387727/checking-for-empty-queryset-in-django — tatlar, Apr 24 '18 at 16:56
or you use the built in shortcut function `get_list_or_404` [Docs](https://docs.djangoproject.com/en/dev/topics/http/shortcuts/#get-list-or-404) — Philipp Zettl, Apr 24 '18 at 17:06

score 5 · Answer 1 · edited Sep 15 '20 at 07:10

5

Try this:

queryset = demo.objects.filter(name="non_existent_name")

if queryset:
    serializer = DemoSerializer(queryset, many=True)
    return Response(serializer.data)
else:
    return Response(status=status.HTTP_404_NOT_FOUND)

edited Sep 15 '20 at 07:10

NearHuscarl

66,950
18
261
230

answered Sep 14 '20 at 20:51

Chamunorwa Nziradzemhuka

51
1
3

What is the proper way to check an empty queryset in Django?

1 Answers1