how to constantly change display property with javascript

Question

Script:

  let menu =  function(){
        var obj = document.getElementById("hidden")
        if(obj.style.display = "block"){
           obj.style.display = "none"
       //hide the div element with an ID #Hidden
        }else{
           obj.style.display = "block"
       //else show it 
        }
      }

        // I tried using buttons too, same result.

CSS

div#hidden{
       display:none;

    }

HTML:

<a href="javascript:menu()"id="info" > INFO </a> 

<div id="hidden">
     <!-- some stuff -->
</div>

I'm trying to "constantly" change the display property of my DIV element with an ID "hidden" to show and hide -VICEVERSA

my javascript code

Apparently this code runs but! it won't run or do anything to my code the second time this event is called.

the codes inside the if statements are executed but doesn't do anything or change my display property

You need to post your code **in the question**, with relevant markup and in a snippet so we can run it. — Reinstate Monica Cellio, May 07 '18 at 11:42
You should provide a [mcve] *in the question itself*, preferably as a [live demo](https://stackoverflow.blog/2014/09/16/introducing-runnable-javascript-css-and-html-code-snippets/). Don't just link to fuzzy pictures of text. — Quentin, May 07 '18 at 11:42
Duplicate: https://stackoverflow.com/questions/2063480/the-3-different-equals — Quentin, May 07 '18 at 11:43

PaulShovan · Answer 1 · 2018-05-07T11:52:28.590

1

Your if statement is incorrect. Do it as following

obj.style.display === "block"

here you can find more about comparison operator in javascript

edited May 07 '18 at 11:52

answered May 07 '18 at 11:43

PaulShovan

2,140
1
13
22

score 1 · Answer 2 · edited May 07 '18 at 12:22

1

You should use the comparison operators (== or ===) in if statements, not the assignment operator (=)

edited May 07 '18 at 12:22

Jesse

3,522
6
25
40

answered May 07 '18 at 11:57

Mücahit Inel

120
11

score 0 · Accepted Answer · answered May 07 '18 at 11:48

0

see code below:

function func(){
var obj=document.getElementById("hidden");
if(obj.style.display==="block")
obj.style.display="none"
else
obj.style.display="block"
}

<p id="hidden" style="display:none">I am the text<p>
<button onclick="func()">click me</button>

answered May 07 '18 at 11:48

לבני מלכה

15,925
2
23
47

tell for more help – לבני מלכה May 07 '18 at 11:52
I can't believe how I miss this, I already used === this for my if Statements but it never worked out. – WEEFA May 07 '18 at 11:52
dude, you don't know how much I changed my code just to figure this out. Thanks Man ! – WEEFA May 07 '18 at 11:52
I can't at the moment, I need to wait 3 mins more for me to toggle it :'( -- sorry, my bad wait a sec – WEEFA May 07 '18 at 11:53
Done :) It has a time duration for me to put a check on it thanks again – WEEFA May 07 '18 at 11:57

how to constantly change display property with javascript

3 Answers3