Href having echo does not work in php 7

Question

I am having this piece of php code. Which was working on php 5. Recently I updated to php 7 and its not working. Is there anything missing after upgrading to php 7. Here is my php code:

 <?
define ("ROOT_DIR", "http://".$_SERVER['HTTP_HOST']."/"); ?>
        <link rel="stylesheet" type="text/css"  href="<?echo ROOT_DIR?>main.css"/>

Its unable to load main.css and also there are few links like:

<li> <a href="<?echo ROOT_DIR?>mapshop/index.php" >Mapshop test tools</a> </li>
                                <li> <a href="<?echo ROOT_DIR?>mapshop/certificate.php" >Durham certificate test</a> </li>

When I take mouse over these links, it shows http://myserver.com/<?echo ROOT_DIR?>mapshop/index.php. Its not parsing/executing the echo command which I am expecting.

Does it work if you add semi-colons after the echo ROOT_DIR? — Can O' Spam, May 10 '18 at 10:27
@Paul — That's a `` and an `echo` without the (optional) space between them. — Quentin, May 10 '18 at 10:30
Yea thanks, after seeing the duplicate question you added, I started realizing what's going on. — Paul, May 10 '18 at 10:30

caramba · Answer 1 · 2018-05-10T10:44:42.173

0

change

<?echo ROOT_DIR?>

to

<?php echo ROOT_DIR ?>
<!-- |             |    
     |             |    
     +-------------+------------ make sure to add those spaces!

edited May 10 '18 at 10:44

answered May 10 '18 at 10:28

caramba

21,963
19
86
127

1

@Downvoter, commenting your downvote would be much appreciated. – caramba May 10 '18 at 10:39

Href having echo does not work in php 7

1 Answers1