Two requests with same map

Question

I need to get user information by ID and by Username. Can I have 2 requests like this?

 @GetMapping("/user/{id}")
public User getUser(@PathVariable Long id) {
    return userRepository.getOne(id);
}

@GetMapping("/user/{username}")
public User getUser(@PathVariable String username) {
    return userRepository.findUserByUsername(username);
}


public interface UserRepository extends JpaRepository<User,Long>{

@Query("SELECT u FROM u WHERE username= :#{username}")
User findUserByUsername(@Param("username") String username);
}

Error: findUserByUsername(java.lang.String) but parameter 'Optional[username]' not found in annotated query 'SELECT u FROM u WHERE username= :#{username}'!

i mean. how does it know if it's an id or a username. Can I do this? — , May 16 '18 at 14:27
instead of using 2 different end points use same endpoint and return based on the condition weather it is Id / username — Kiran Kumar, May 16 '18 at 14:31
btw if any of the answers helped you, you could accept that answer https://meta.stackexchange.com/questions/5234/how-does-accepting-an-answer-work — Eugene, May 17 '18 at 08:56

score 5 · Answer 1 · edited May 16 '18 at 14:50

5

If I remember correctly you can do that via a regex like:

@GetMapping("/user/{id:[\\d]+}")
@GetMapping("/user/{username:^[a-fA-F]{100}$}")

edited May 16 '18 at 14:50

Arnaud

17,229
3
31
44

answered May 16 '18 at 14:35

Eugene

117,005
15
201
306

Didn't know about that, it looks like you are right , cf. https://stackoverflow.com/questions/20527321/what-is-the-meaning-of-id-in-a-spring-mvc-requestmapping-handler-method – Arnaud May 16 '18 at 14:46
@Berger I *vaguely* remember this to be honest, had to do it quite a lot of time ago – Eugene May 16 '18 at 14:47

score 2 · Answer 2 · answered May 16 '18 at 14:34

No, You can't do that as both requests can be mapped to both the methods. A Better way to do it would be to,

@GetMapping("/user")
public User getUser(@RequestParam("username") String username, @RequestParam("userId") Long userId) {
   // find by Criteria.
}

And Call it like,

http://<host>:<port>/<context>/user?userId=123&username=abc, the query params atre optional and so you can omit whatever isn't needed.

score 0 · Answer 3 · answered May 16 '18 at 14:34

0

HTTP is a text based protocol so the path parameter is always a string.

You should solve that with @RequestParam.

answered May 16 '18 at 14:34

saferJo

497
1
5
16

score 0 · Answer 4 · answered May 16 '18 at 14:49

You can do it with request parameter:

@GetMapping(value = "/user", params = "id")
public User getUser(@RequestParam("id") Long id) {
    return userRepository.getOne(id);
}

@GetMapping(value = "/user", params = "username")
public User getUser(@RequestParam("username") String username) {
    return userRepository.findUserByUsername(username);
}

Two requests with same map

4 Answers4