nodejs seems to run out of order

Asked May 18 '18 at 15:01

Active May 18 '18 at 15:01

Viewed 23 times

I have this function:

app.post('/list', function(req,res){
var imagelist=[]
var list=req.body.list
console.log("posted this: "+list)   
list=list.split("\n")
console.log("starting for each")
list.forEach(function(card) {       
    mtg.card.where({name:card}).then(cards=> {
        var url =cards[0].imageUrl
        if(url){
        imagelist.push(cards[0].imageUrl)
        } else{
            console.log("no such card")
        }
        console.log("get url: "+imagelist)      
    })  
})
console.log("render"+imagelist)

    res.render('list',{
        list:list,
        imagelist:imagelist[0]
  })
})

this functions results in this log:

server start
posted this: squee
starting for each
render
get url: http://gatherer.wizards.com/Handlers/Image.ashx?multiverseid=370461&type=card

the render function is called before the imagelist is filled, I don't know why.

all code can be found here: https://github.com/JasonElting/mtgapp

asked May 18 '18 at 15:01

user3294794

1,159
1
6
5

`mtg.card.where` is asynchronous, you have to wait until it finishes before rendering. – Marcos Casagrande May 18 '18 at 15:07
ok, did not know that, so i need to have a thing that joins with mtg.card.where thanks. – user3294794 May 18 '18 at 15:12
should i delete this then? – user3294794 May 18 '18 at 15:12
You can push promises to an array, and use `Promise.all` to wait until all your data is retrieved. – Marcos Casagrande May 18 '18 at 15:14

nodejs seems to run out of order

0 Answers0