Calling methods with different parameters using a map instead of switch/if else

Question

I am working a c# method which calls different methods based on some conditions and I am wondering if I can do this without switch or if else statements. Below is the code I have

if (msg== atype)
{
    _aHandler.HandleAType(msg, TopicType.A);
}
else if (msg== btype)
{
    _
    _btype.HandleBType(msg, TopicType.B);
}
else if (msg== ctype)
{
    _cHandler.HandleC(msg);
}
else if (msg== dtype)
{
    _dHandler.HandleDType(msg);
}

else
    _logger.Error($"No matching type found for {msg}");

Please note that I have different methods with different types of parameters in each condition.

Is there a better way I can do this without switch/if-else ?

`_aHandler` , `_cHandler` are objects of classes inherited from the same base class or interface? — Chetan, May 22 '18 at 15:34
@ChetanRanpariya No they are not. each condition may or may not have methods from same base class or different — DoIt, May 22 '18 at 15:35
looks very similar to another question https://stackoverflow.com/questions/5416500/understanding-the-open-closed-principle — Dmitry Pavliv, May 22 '18 at 15:44
No, there is not a better way. You could throw a `#region` around it if it's really bothering you. — 15ee8f99-57ff-4f92-890c-b56153, May 22 '18 at 16:17

score 3 · Accepted Answer · answered May 22 '18 at 15:42

3

You mean something like this:

var dic = new Dictionary<string, Action>
{
    {atype, () => _aHandler.HandleAType(atype, TopicType.A)},
    {btype, () => _btype.HandleBType(btype, TopicType.B)},
    {ctype, () => _cHandler.HandleC(ctype)},
    {dtype, () => _dHandler.HandleDType(dtype)}
};

//Call it
dic[msg]();

answered May 22 '18 at 15:42

Magnus

45,362
8
80
118

I can't see how this improves on the readability or maintainability of OP's original version. – 15ee8f99-57ff-4f92-890c-b56153 May 22 '18 at 16:16
@EdPlunkett Not really no, but he specifically asked for an implementation _"using a map instead of switch/if else"_ so I assume it is for educational purposes. – Magnus May 22 '18 at 18:55
OK, fair enough. – 15ee8f99-57ff-4f92-890c-b56153 May 22 '18 at 18:56
Maintenance is obviously a subjective topic, what Magnus has is far better as far as cyclomatic complexity is concerned. – sy-huss Jun 30 '22 at 06:25

Calling methods with different parameters using a map instead of switch/if else

1 Answers1

Related