Override new operator in C++ while crtdbg.h is causing conflicts

Question

While trying out some memory tracking and preparation for my own memory manager, I tried to override the new operator. The article on flipcode was my main guideline in this process ( http://www.flipcode.com/archives/How_To_Find_Memory_Leaks.shtml ).

After implementing the techniques described in that article, I am left with the problem that somewhere in the STL the "crtdbg.h" is being included either directly or indirectly through some of the header-files that are being included (Using Visual Studio 2010).

This results in an error:

[...]10.0\vc\include\crtdbg.h(1078): error C2365: 'operator new' : redefinition; previous definition was 'function'
[...]10.0\vc\include\crtdbg.h(1078): error C2078: too many initializers
[...]

Doing a quick-check by placing the '_CrtDumpMemoryLeaks()' without including the header-files confirms my suspicion that the header-files are indeed incuded through the STL files.

// The header files that should be included for using the CrtDumpMemoryLeaks:
//#define _CRTDBG_MAP_ALLOC
//#include <stdlib.h>
//#include <crtdbg.h>
//...
_CrtDumpMemoryLeaks()

Leaving aside wether it's a good idea or not to implement my own new/delete, I am wondering how I can have my own new/delete implementations while still using some standard library functionality and not having these redefinition errors.

The code looks like this:

memdebug.h

#ifndef _MEM_DEBUG_H
#define _MEM_DEBUG_H

#ifdef _DEBUG
    void * operator new( unsigned int size, const char *filename, int line );
    void operator delete( void *ptr );

    #define DEBUG_NEW new(__FILE__, __LINE__)
    #define new DEBUG_NEW
#endif

#endif

memdebug.c

#ifdef _DEBUG
void * operator new( unsigned int size, const char *filename, int line )
{
    void *ptr = (void *)malloc(size);
    //AddTrack((DWORD)ptr, size, filename, line);
    return(ptr);
};

void operator delete( void *ptr )
{
    //RemoveTrack( (DWORD)ptr );
    free( ptr );
}
#endif

main.cpp

#include "memdebug.h"
#include <iostream>

void main()
{
    Test *pTest = new Test();
    std::cout << "end" << std::endl;
}

The way I solved it is by moving the #define new DEBUG_NEW below the <iostream>; The problem is resolved, since it won't rewrite the new in the crtdbg.h; however this really makes it troublesome having to make sure that this is always being done after possible headers that include the crtdbg.h file.

I believe this can only be resolved by using a custom name for the new operator and use that one instead. Am I correct?

Doing some more research I found out that the problem happens with the re-#define of new: "#define DEBUG_NEW new(__FILE__, __LINE__) #define new DEBUG_NEW". This causes the that is included after that #define to re-write the 'new' that is included in the crtdbg.h that is somehow included through the include; This causes the whole mess-up that's happening after it. This article describes the problem quite well: http://www.flipcode.com/archives/Detecting_Memory_Leaks.shtml, basically coming down to the argument that overriding the 'new' is dangerous exactly because of this — Evil Activity, Feb 19 '11 at 21:41

score 3 · Accepted Answer · answered Feb 20 '11 at 13:17

Allright, the way I solved it for now, without having to use a custom 'new' define is that I've made a generic header file, let's say 'Engine.h' that is included in every file. This can be enforced by using the Forced Include File in the Project Settings / Configuration Properties / C/C++ / Advanced.

This file contains the #define (removed from the memdebug.h)

engine.h

#define _CRTDBG_MAP_ALLOC
#include <stdlib.h>
#include <crtdbg.h>

#include <windows.h>

#include "MemoryNappy.h"

#define DEBUG_NEW new(__FILE__, __LINE__)
#define new DEBUG_NEW

This enforces the system to consider the crtdbg.h before the custom new-define and won't be changing the new there. The second time it's included somewhere down the line, it's just using the data that has already been loaded before. (In the case of including <iostream> after the include of "engine.h").

Please note that overriding the new operator is still risky business when using third party libraries that might do the same trick. This causes the new operator for those files to be rewritten using the pattern used here. In that case you might want to reconsider the usage of a custom new define as in this fragment:

#define myNew new(__FILE__, __LINE__)

(Also described in http://www.flipcode.com/archives/Detecting_Memory_Leaks.shtml)

score 2 · Answer 2 · answered Feb 19 '11 at 22:23

In one application of ours we resorted to renaming everywhere at the application level new with xnew and then defining the debug macro as acting only on xnew.

Using new and redefining it as a macro can have problems also with custom allocators. Unfortunately C++ syntax for allocation made debugging wrappers harder to do.

score 0 · Answer 3 · answered Mar 27 '13 at 18:42

On Visual Studio 2010, I was able to do this without redefinition of new or custom defined new. I created a header file with the following:

#pragma once
//_CRTDBG_MAP_ALLOC
//_CRTDBG_MAP_ALLOC_NEW
#define _CRTDBG_MAP_ALLOC
#define _CRTDBG_MAP_ALLOC_NEW
#include <stdlib.h>
#include <crtdbg.h>

and forced its inclusion on every source file, with the already discussed option Forced Include File, in the Project Settings / Configuration Properties / C/C++ / Advanced. Actually, crtdbg.h already do this custom definition of new, along with undefinition of regular new. And just to make sure everything would run smoothy, I added _CRTDBG_MAP_ALLOC and_CRTDBG_MAP_ALLOC_NEW to Preprocessor Definition list, available in: Project Settings / Configuration Properties / C/C++ / Preprocessor.

Hope this will help on this issue.

On VS 2013 and VS 2015, adding the _CRTDBG_MAP_ALLOC_NEW flag only makes all of the lines expand to crtdbg.h which isn't helpful anymore. From the documentation, "These inlines do not add any information, due that __FILE__ is expanded * to "crtdbg.h", which is not very helpful to the user.". — techdude, Aug 04 '15 at 22:50

score -1 · Answer 4 · answered Nov 09 '11 at 05:05

-1

Try _CrtSetDbgFlag(_CRTDBG_ALLOC_MEM_DF | _CRTDBG_LEAK_CHECK_DF); -- as described in my blog post, no new redefinition needed.

answered Nov 09 '11 at 05:05

kizzx2

18,775
14
76
83

Override new operator in C++ while crtdbg.h is causing conflicts

memdebug.h

memdebug.c

main.cpp

4 Answers4

engine.h

Linked