Android - Button onclick no errors but getting "App stopped working"

Question

I want to open my app store link of my app on image click. On mainactivity file, inside the OnCreate, I have added following

    ImageView Button = (ImageView)findViewById(R.id.imageView5);

    Button.setOnClickListener(new OnClickListener() {
        public void onClick(View v) {
            Intent intent = new Intent();
            intent.setAction(Intent.ACTION_VIEW);
            intent.addCategory(Intent.CATEGORY_BROWSABLE);
            intent.setData(Uri.parse("https://play.google.com/store/apps/details?id=APPNAME"));
            startActivity(intent);
        }
    });

And on the layout file, here is my image;

            <ImageView
                android:id="@+id/imageView5"
                android:layout_width="232dp"
                android:layout_height="105dp"
                android:layout_marginTop="10dp"
                android:layout_alignParentTop="true"
                android:layout_centerHorizontal="true"
                android:visibility="visible"
                ads:srcCompat="@drawable/write009" />

Where I am doing mistake ?

UPDATE: Here is what I got from the logcat after debug with virtual device

java.lang.RuntimeException: Unable to start activity
ComponentInfo{antivirus.android.APPNAME/com.APPNAME.activities.MainActivity}:
java.lang.NullPointerException: Attempt to invoke virtual method 'void 
android.view.View.setOnClickListener(android.view.View$OnClickListener)' on a 
null object reference

http://stackoverflow.com/questions/23353173, https://developer.android.com/studio/debug/am-logcat — Mike M., May 26 '18 at 10:56
Possible duplicate of [What is a NullPointerException, and how do I fix it?](https://stackoverflow.com/questions/218384/what-is-a-nullpointerexception-and-how-do-i-fix-it) — Zoe, May 27 '18 at 19:08

score 2 · Answer 1 · answered May 26 '18 at 10:45

Without the crash log its hard to guess the problem but I think that you should not use the addCategory(Intent.CATEGORY_BROWSABLE) in your intent.

ImageView button = (ImageView)findViewById(R.id.imageView5);

button.setOnClickListener(new OnClickListener() {
    public void onClick(View v) {
        Intent intent = new Intent(Intent.ACTION_VIEW);
        intent.setData(Uri.parse("https://play.google.com/store/apps/details?id=APPNAME"));
        startActivity(intent);
    }
});

score 1 · Answer 2 · answered May 26 '18 at 14:02

Try using this

<ImageView
                android:id="@+id/imageView5"
                android:layout_width="232dp"
                android:layout_height="105dp"
                android:layout_marginTop="10dp"
                android:layout_alignParentTop="true"
                android:layout_centerHorizontal="true"
                android:visibility="visible"
                android:src="@drawable/write009" />

change ads:srcCompat to android:src.

score 1 · Answer 3 · answered May 26 '18 at 14:23

According to LogCat, your variable Button is null - findViewById() couldn't find R.id.imageView5. Are you sure you edited the right layout file? Are you loading this layout file on the beggining of your Activity onCreate() using setContentView(R.layout.your_layout_name)?

Also, you could try changing the variable name to lowercase button, maybe it clashes with class Button (I doubt this, but strange stuff happens)

Android - Button onclick no errors but getting "App stopped working"

3 Answers3