1

I have a UserControl (FahrtControl.xaml) with a ListView. This UserControl is bound to an ItemsControl in my MainWindow.xaml. The MainWindow has its own ViewModel and the FahrtControl has its own ViewModel. I now want to bind the Background of the Listview items to a Brush property in the ViewModel of FahrtControl.

Here are the relevant parts of my code:

MainWindow.xaml:

<Window x:Class="WpfFrontend.Forms.Main.MainWindow"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
    xmlns:local="clr-namespace:WpfFrontend.Forms.Main"
    xmlns:fahrtControl="clr-namespace:WpfFrontend.Controls.FahrtControl"
    mc:Ignorable="d">
<Window.DataContext>
    <local:MainViewModel />
</Window.DataContext>
<Window.Resources>
    <DataTemplate DataType="{x:Type fahrtControl:FahrtControlViewModel}">
        <fahrtControl:FahrtControl />
    </DataTemplate>
</Window.Resources>
<ItemsControl ItemsSource="{Binding Fahrten, UpdateSourceTrigger=PropertyChanged}" />

MainViewModel.cs:

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.ComponentModel;
using System.Linq;
using System.Runtime.CompilerServices;
using System.Windows.Controls;
using System.Windows.Media;

using Backend;

using DatabaseCommunication;

using WpfFrontend.Annotations;
using WpfFrontend.Controls.FahrtControl;


namespace WpfFrontend.Forms.Main
{
    public class MainViewModel : INotifyPropertyChanged
    {
        public MainViewModel ()
        {
            SyncFahrten ();
        }

        private void SyncFahrten ()
        {
            var fahrtenPromise =
                MainUtility.GetFahrtenToRangeAsync (GlobalProperties.Start, GlobalProperties.Start.AddDays (6));

            fahrtenPromise.Task.GetAwaiter ().OnCompleted (() =>
            {
                AddFahrten (fahrtenPromise.Task.Result);
            });
        }

        private void AddFahrten (List <ExtendedFahrt> fahrten)
        {
                foreach (var fahrtControlViewModel in
                    fahrten.Select (fahrt =>
                                 {
                                     return new FahrtControlViewModel (
                                         Brushes.Red, Brushes.Red, Brushes.White,
                                         fahrt.Ort,
                                         new ObservableCollection <string>
                                         {
                                             fahrt.Bemerkung
                                         }, new ObservableCollection <KundeDisplay> (fahrt.Kunden));
                                 }))
                    Fahrten.Add (fahrtControlViewModel);

            OnPropertyChanged ("");
        }



        private ObservableCollection <FahrtControlViewModel> _fahrten =
            new ObservableCollection <FahrtControlViewModel> ();

        public ObservableCollection <FahrtControlViewModel> Fahrten
        {
            get => _fahrten;
            set
            {
                if (Equals (value, _fahrten))
                    return;
                _fahrten = value;
                OnPropertyChanged ();
            }
        }

        public event PropertyChangedEventHandler PropertyChanged;

        [NotifyPropertyChangedInvocator]
        protected virtual void OnPropertyChanged ([CallerMemberName] string propertyName = null) =>
            PropertyChanged?.Invoke (this, new PropertyChangedEventArgs (propertyName));
    }
}

FahrtControl.xaml:

<UserControl x:Class="WpfFrontend.Controls.FahrtControl.FahrtControl"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:local="clr-namespace:WpfFrontend.Controls.FahrtControl"
             mc:Ignorable="d"
             d:DesignHeight="300" d:DesignWidth="300">
    <UserControl.Resources>
        <Style x:Key="HeaderStyle" TargetType="{x:Type GridViewColumnHeader}">
            <Setter Property="Visibility" Value="Collapsed" />
        </Style>
    </UserControl.Resources>
    <ListView ItemsSource="{Binding Kunden}"
              Background="{Binding KundenBrush, UpdateSourceTrigger=PropertyChanged}">
        <ListView.ItemContainerStyle>
            <Style TargetType="ListViewItem">
                <Setter Property="Background" Value="{Binding DataContext.KundenBrush}" />
            </Style>
        </ListView.ItemContainerStyle>
        <ListView.View>
            <GridView ColumnHeaderContainerStyle="{StaticResource HeaderStyle}">
                <GridViewColumn DisplayMemberBinding="{Binding Name}" Header="Name" />
            </GridView>
        </ListView.View>
    </ListView>
</UserControl>

FahrtControlViewModel.cs:

using System;
using System.Collections.Generic;
using System.Collections.ObjectModel;
using System.ComponentModel;
using System.Runtime.CompilerServices;
using System.Windows.Media;

using Backend;

using WpfFrontend.Annotations;
using WpfFrontend.Misc;


namespace WpfFrontend.Controls.FahrtControl
{
    public class FahrtControlViewModel : INotifyPropertyChanged
    {
        private Brush                               _kundenBrush = Brushes.Red;
        private ObservableCollection <KundeDisplay> _kunden;

        /// <inheritdoc />
        public FahrtControlViewModel (
            Brush                               kundenBrush,
            ObservableCollection <KundeDisplay> kunden)
        {
            Kunden         = kunden;
            KundenBrush    = kundenBrush;
        }
        public Brush KundenBrush
        {
            get => _kundenBrush;
            set
            {
                if (value.Equals (_kundenBrush))
                    return;
                _kundenBrush = value;
                KundenDark   = _kundenBrush.IsDark ();

                OnPropertyChanged ();
            }
        }

        public ObservableCollection <KundeDisplay> Kunden
        {
            get => _kunden;
            set
            {
                if (Equals (value, _kunden))
                    return;
                _kunden = value;
                OnPropertyChanged ();
            }
        }


        public event PropertyChangedEventHandler PropertyChanged;

        [NotifyPropertyChangedInvocator]
        protected virtual void OnPropertyChanged ([CallerMemberName] string propertyName = null) =>
            PropertyChanged?.Invoke (this, new PropertyChangedEventArgs (propertyName));
    }
}

I've already tried the following:

And if I had to guess every other suggestion slightly related to the topic. What am I doing wrong here? Does it have something to do with the fact that I'm using a UserControl inside an ItemsControl? Other property bindings, not enclosed by a style tag, work inside the my UserControl, so it must have something to do with the style tag, doesn't it?

Bizhan
  • 16,157
  • 9
  • 63
  • 101
MetaColon
  • 2,895
  • 3
  • 16
  • 38
  • Use PresentationTraceSources.TraceLevel=High in binding to debug it. Is your KundenBrush correctly set? Then use UI Debugging Tools, to explore if ListViewItems have their background set. – Maciek Świszczowski May 29 '18 at 23:57

1 Answers1

1

DataContext of ListView.ItemContainerStyle is not the same as ListView's. you can either find the correct data context with its element name:

<UserControl x:Class="WpfFrontend.Controls.FahrtControl.FahrtControl"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:local="clr-namespace:WpfFrontend.Controls.FahrtControl"
             mc:Ignorable="d"

             <!--      -->
             x:Name="root"
             <!--      -->

             d:DesignHeight="300" d:DesignWidth="300">
    <UserControl.Resources>
        <Style x:Key="HeaderStyle" TargetType="{x:Type GridViewColumnHeader}">
            <Setter Property="Visibility" Value="Collapsed" />
        </Style>
    </UserControl.Resources>
    <ListView ItemsSource="{Binding Kunden}"
              Background="{Binding KundenBrush, UpdateSourceTrigger=PropertyChanged}">
        <ListView.ItemContainerStyle>
            <Style TargetType="ListViewItem">

             <!--      -->
                <Setter Property="Background" Value="{Binding ElementName=root, Path=DataContext.KundenBrush}" />
             <!--      -->
            </Style>
        </ListView.ItemContainerStyle>
        <ListView.View>
            <GridView ColumnHeaderContainerStyle="{StaticResource HeaderStyle}">
                <GridViewColumn DisplayMemberBinding="{Binding Name}" Header="Name" />
            </GridView>
        </ListView.View>
    </ListView>
</UserControl>

Or by tracing up the element tree:

<UserControl x:Class="WpfFrontend.Controls.FahrtControl.FahrtControl"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
             xmlns:local="clr-namespace:WpfFrontend.Controls.FahrtControl"
             mc:Ignorable="d"
             d:DesignHeight="300" d:DesignWidth="300">
    <UserControl.Resources>
        <Style x:Key="HeaderStyle" TargetType="{x:Type GridViewColumnHeader}">
            <Setter Property="Visibility" Value="Collapsed" />
        </Style>
    </UserControl.Resources>
    <ListView ItemsSource="{Binding Kunden}"
              Background="{Binding KundenBrush, UpdateSourceTrigger=PropertyChanged}">
        <ListView.ItemContainerStyle>
            <Style TargetType="ListViewItem">

             <!--      -->
                <Setter Property="Background" Value="{Binding RelativeSource={RelativeSource AncestorType=FahrtControl}, Path=DataContext.KundenBrush}" />
             <!--      -->
            </Style>
        </ListView.ItemContainerStyle>
        <ListView.View>
            <GridView ColumnHeaderContainerStyle="{StaticResource HeaderStyle}">
                <GridViewColumn DisplayMemberBinding="{Binding Name}" Header="Name" />
            </GridView>
        </ListView.View>
    </ListView>
</UserControl>
Bizhan
  • 16,157
  • 9
  • 63
  • 101
  • Remove `Background` from `ListView` declaration if you are setting it in `Style`. – AnjumSKhan May 30 '18 at 07:05
  • @AnjumSKhan Background isn't set in ListView's Style and I think OP wants to set background of both ListView and its ItemContainerStyles – Bizhan May 30 '18 at 11:16