21

I have a set of simple tool methods, without any state to share along the app, not need to be a singleton and without any injected services.

Do I have any advantage to use a injectable service :

@Injectable()
export class DateService { 
  public convertStringToDate(input: string): Date {
    …
  }

  public convertDateToString(date: Date): string {
   …
  }
  …
}

versus a simple set of export/import functions (or basic JS module)? 

export function convertStringToDate(input: string): Date {
    …
}

export function convertDateToString(date: Date): string {
   …
}

…

I'm working on a app mixing both method and I confused about the advantage of each others.

Yoann Augen
  • 1,966
  • 3
  • 21
  • 39

5 Answers5

24

If a service doesn't have any state, then there is no need to create that service.

Exporting functions has the advantage that during the build process code can be removed, if one of the functions is not used.

If your application has more than one code bundles and they are loaded lazily, and you use different functions in different bundles, then the functions are loaded lazily with that bundles.

If you are confident that your functions will always used independently then I'd go with the second approach. RxJS e.g. moved to the function approach for the reasons I stated.

One argument for using a service is testing. You can easily inject a fake service or a proxy during testing, if necessary. But I guess that's hardly necessary for conversion functions.

a better oliver
  • 26,330
  • 2
  • 58
  • 66
1

I don't think either has an advantage over the other in your case. Because it doesn't need to contain state, then there are no real differences.

If you incorporate lazy loading in your application, maybe you'll have some advantage in performance since you will not eagerly load the module that contains that service until it is needed. But other than that, no.

filipbarak
  • 1,835
  • 2
  • 17
  • 28
0

@Injectable use when you have conman functionality for multiple component and you don't want to declare multiple times than just declare it in your @Injectable component and use it any components.

mittal bhatt
  • 955
  • 6
  • 13
  • You will still need to call it in the constructor of a component, though. With the module approach you will have to import them. So it's the same code, give or take several characters. – filipbarak May 30 '18 at 12:36
0

If you just want to convert a Date to a String, i would recommend to use the JavaScript Date API or the Angular DatePipe.

Anyway, if you just need static methods there is no advantage of using a service. A service is used as a layer between components and a server, in order to retrieve and object, store them and, manage them. It makes sense to store helper functions in an extra TypeScript file that can be accessed from anywhere.

user7646788
  • 116
  • 1
  • 2
-1

A big advantage of export over service .. is that you could use it in a module

services could only be injected to component , not modules ..

yaniv
  • 152
  • 5
  • 15