Bash purge script

Question

I'm trying to create a script that removes my images that are not in DB

There is my code (Updated): I have 1 problems:

Problem with the like syntax like '%$f%'

#!/bin/bash

db="intranet_carc_development"
user="benjamin"

for f in public/uploads/files/*
do
  if [[ -f "$f" ]]
  then
    psql $db $user -t -v "ON_ERROR_STOP=1" \
    -c 'select * from public.articles where content like "%'"$(basename "$f")"'%"' | grep . \
    && echo "exist" \
    || echo "doesn't exist"
  fi
done

And I have the following error :

ERROR:  column "%1YOLV3M4-VFb2Hydb0VFMw.png%" does not exist
LINE 1: select * from public.articles where content like "%1YOLV3M4-...
                                                         ^
doesn't exist
ERROR:  column "%wnj8EEd8wuJp4TdUwqrJtA.png%" does not exist
LINE 1: select * from public.articles where content like "%wnj8EEd8w...

EDIT : if i use \'%$f%\' for the like :

/purge_files.sh: line 12: unexpected EOF while looking for matching `"'
./purge_files.sh: line 16: syntax error: unexpected end of file

[Don't parse 'ls'](https://mywiki.wooledge.org/ParsingLs). You don't even need the `tab2` variable. Try `for f in public/uploads/files/*; do ...`. — Aserre, Jun 01 '18 at 08:58
ha you one exemple , @Arount ? don't really understand how to do — Benjamin Barbé, Jun 01 '18 at 13:06
append a line before `if test -f "$f"` like `f="$(basename "$f")"` — Arount, Jun 01 '18 at 13:07

Aserre · Accepted Answer · 2018-06-02T12:42:48.730

There are several issues with your code :

$f is public/uploads/files/FILENAME and i want only the FILENAME

You can use basename to circumvent that, by writing :

f="$(basename "$f")"
psql $db $user -c "select * from public.articles where content like '%$f%'"...

(The extra quotes are here to prevent issues if you have spaces and special characters in your file name)

your psql request will always return true even if no rows are found
your psql command will return true even if the request fails, unless you set the variable 'ON_ERROR_STOP' to 1

As shown in the linked questions, you can use the following syntax :

#!/bin/bash

set -o pipefail #needed because of the pipe to grep later on

db="intranet_carc_development"
user="benjamin"

for f in public/uploads/files/*
do
  if [[ -f "$f" ]]
  then
    f="$(basename "$f")"
    psql $db $user -t -v "ON_ERROR_STOP=1" \
    -c "select * from public.articles where content like '%$f%'" | grep . \
    && echo "exist" \
    || echo "doesn't exist"
  fi
done

Post updated , Thanks , the first problem is solved but i have the same problem for the Like syntax : i want something like : 'select ...... like '% $(basename)%' ' — Benjamin Barbé, Jun 01 '18 at 13:52
@BenjaminBarbé Updated, I think psql didn't like the double quotes. I simplified the syntax a bit. — Aserre, Jun 01 '18 at 14:02
Thanks ! it's up to me now to finish correctly but I'm in the right direction — Benjamin Barbé, Jun 04 '18 at 11:36

Bash purge script

1 Answers1