Firebase Storage getDownloadUrl() method can't be resolved

Question

To upload images to Firebase Storage I am attaching addOnSuccessListener on the instance of the StorageReference. While overriding onSuccess method I am calling getDownloadUrl() on the instance of taskSnapshot but it is giving me an error saying

Can't resolve method getDownloadUrl()

This app I had created 2 months ago, earlier this app was working fine and getDownloadUrl() was working fine as well. Also, in taskSnapshot instance when I press Ctrl+space, in the suggestions I don't find getDownloadUrl() method. Why is it happening?

Code to onActivityResult():

@Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);

    if(requestCode == RC_SIGN_IN) {
        if (resultCode == RESULT_OK) {
            Toast.makeText(this, "Signed in!!!1", Toast.LENGTH_SHORT).show();
        } else if (resultCode == RESULT_CANCELED) {
            Toast.makeText(this, "Failed to sign in", Toast.LENGTH_SHORT).show();
            finish();
        }
    }
    else if(requestCode == RC_PHOTO_PICKER && resultCode == RESULT_OK){
        Uri selectedPhoto = data.getData();

        StorageReference localRefrence = storageReference.child(selectedPhoto.getLastPathSegment());

        //  Uploading the file on the storage
        localRefrence.putFile(selectedPhoto).addOnSuccessListener(new OnSuccessListener<UploadTask.TaskSnapshot>() {
            @Override
            public void onSuccess(UploadTask.TaskSnapshot taskSnapshot) {
                 Uri downloadUrl = taskSnapshot.getDownloadUrl();

                FriendlyMessage message = new FriendlyMessage(mUsername, null, downloadUrl.toString());
                databaseReference.push().setValue(message);
            }
        });
    }
}

After going through related questions I've also tried `@SuppressWarnings("VisibleForTests") Uri downloadUrl = taskSnapshot.getDownloadUrl();` but still getting the same error. — Neeraj Sewani, Jun 02 '18 at 20:45
@JosefKorbel It shows `getDownloadUrl()` in red that's why I've added that. — Neeraj Sewani, Jun 02 '18 at 20:49
Yes but we are unable to copy and replicate, no one will rewrite it from a screenshot. — Josef Korbel, Jun 02 '18 at 20:50
It's strongly preferable to copy your code into the question instead of showing a screenshot that can be difficult to read and impossible to search. — Doug Stevenson, Jun 02 '18 at 20:50
Possible duplicate of [Firebase Storage "retrieves a long lived download URL" using getDownloadUrl() now deprecated](https://stackoverflow.com/questions/50158921/firebase-storage-retrieves-a-long-lived-download-url-using-getdownloadurl-no) — Peter Haddad, Jun 12 '18 at 06:03

score 24 · Accepted Answer · edited Jun 20 '20 at 09:12

24

The Firebase API has changed.

May 23, 2018

Cloud Storage version 16.0.1

Removed the deprecated StorageMetadata.getDownloadUrl() and UploadTask.TaskSnapshot.getDownloadUrl() methods. To get a current download URL, use StorageReference.getDownloadUr().

UploadTask.TaskSnapshot has a method named getMetadata() which returns a StorageMetadata object.

This StorageMetadata object contains a method named getReference() which returns a StorageReference object.

That StorageReference object contains the getDownloadUrl() method, which now returns a Task object instead of an Uri object.

This Task must then be listened upon in order to obtain the Uri, which can be done asynchronously or in a blocking manner; see the Tasks API for that.

edited Jun 20 '20 at 09:12

Community

1
1

answered Jun 02 '18 at 20:49

Daniel F

13,684
11
87
116

1

I had invoked `getDownloadUrl()` on the instance of `TaskSnapshot` and at that time it was returning `Uri` but now it's returning `Task`. Did the method of invoking `getDownloadUrl()` method get change in the past few months? – Neeraj Sewani Jun 02 '18 at 21:06
1

See the modified answer, it got deprecated on May 23 2018. So yes, you now must get the Uri via the Task object. – Daniel F Jun 02 '18 at 21:12
1

@Daniel F In `onSuccess()` I wrote `Task downloadUri=taskSnapshot.getMetadata().getReference().getDownloadUrl(); Log.i("url:",downloadUri.getResult().toString());` but it thows `Exception` 'java.lang.IllegalStateException: Task is not yet complete' Please help – Bhagyashri Jun 12 '18 at 09:21
2

@userI The downloadUri is a Task. You have two options. either call `Tasks.await(downloadUri)`before you call `downloadUri.getResult()` (but only do this if you are in a background thread!!!), or use `downloadUri.addOnCompleteListener(...)` as shown in https://developers.google.com/android/guides/tasks – Daniel F Jun 12 '18 at 09:47
3

@userI I must correct one thing: if you are in a background thread, you can call `theUri = Tasks.await(downloadUri)` because `downloadUri.getResult()` is only called inside `downloadUri.addOnCompleteListener(...)`. It could possibly also be called after `Tasks.await(downloadUri)`, but there would be no need to do so since `await` is already returning the result. – Daniel F Jun 12 '18 at 09:58
@Daniel F It worked.Thank you so much for your quick help. – Bhagyashri Jun 12 '18 at 10:01

score 6 · Answer 2 · answered Sep 20 '18 at 11:58

You wont get the download url of image now using

profileImageUrl = taskSnapshot.getDownloadUrl().toString(); this method is deprecated.

Instead you can use the below method

uniqueId = UUID.randomUUID().toString();
ur_firebase_reference = storageReference.child("user_photos/" + uniqueId);

Uri file = Uri.fromFile(new File(mphotofile.getAbsolutePath()));
UploadTask uploadTask = ur_firebase_reference.putFile(file);

Task<Uri> urlTask = uploadTask.continueWithTask(new Continuation<UploadTask.TaskSnapshot, Task<Uri>>() {
    @Override
    public Task<Uri> then(@NonNull Task<UploadTask.TaskSnapshot> task) throws Exception {
        if (!task.isSuccessful()) {
            throw task.getException();
        }

        // Continue with the task to get the download URL
        return ur_firebase_reference.getDownloadUrl();
    }
}).addOnCompleteListener(new OnCompleteListener<Uri>() {
    @Override
    public void onComplete(@NonNull Task<Uri> task) {
        if (task.isSuccessful()) {
            Uri downloadUri = task.getResult();
            System.out.println("Upload " + downloadUri);
            Toast.makeText(mActivity, "Successfully uploaded", Toast.LENGTH_SHORT).show();
            if (downloadUri != null) {

                String photoStringLink = downloadUri.toString(); //YOU WILL GET THE DOWNLOAD URL HERE !!!!
                System.out.println("Upload " + photoStringLink);

            }

        } else {
            // Handle failures
            // ...
        }
    }
});

Thank you, this works perfectly, I don't know why your answer is still under-rated. A similar solution can be found on github by LucaUburti, in his post, via this link: [firebase-storage-getDownloadUrl solution link](https://github.com/udacity/and-nd-firebase/issues/41) — Brian, Oct 20 '18 at 08:29

score 4 · Answer 3 · answered Jul 26 '18 at 21:59

final StorageReference filePath = mImageStore.child("profile_images").child("full_image").child(userId + ".jpg");
                filePath.getDownloadUrl().addOnSuccessListener(new OnSuccessListener<Uri>() {
                    @Override
                    public void onSuccess(Uri uri) {
                        //Bitmap hochladen
                        uploadBitMap(uri.toString());
                    }
                });

griffins · Answer 4 · 2019-06-22T10:56:48.290

The .getDownloadURL is no longer available and deprecated. from the documentation Task<Uri> and getdownloadUrl(); Asynchronously retrieves a long lived download URL with a revokable token. see documentation

 @Override 
    public void onSuccess(UploadTask.TaskSnapshot taskSnapshot) {
     Task<Uri> urlTask = taskSnapshot.getStorage().getDownloadUrl(); 
    while (!urlTask.isSuccessful());
     Uri downloadUrl = urlTask.getResult();
//continue with your code

score 1 · Answer 5 · answered Aug 08 '19 at 18:50

1

The getDownloadUrl method has been depreceated. Instead use the following taskSnapshot.getMetadata().getReference().getDownloadUrl().toString()

answered Aug 08 '19 at 18:50

epiphmo

11
1

Agung Pramono · Answer 6 · 2018-12-30T09:47:42.103

You should try this one. Understand it and try to implement in yours

buttonSetup.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {
            String name = editText_name.getText().toString();
            if (!TextUtils.isEmpty(name) && mainImageURI != null) {
                final String user_id = firebaseAuth.getCurrentUser().getUid();
                progressBar_setup.setVisibility(View.VISIBLE);
                final StorageReference image_path = storageReference.child("profile_images").child(user_id + ".jpg");
                UploadTask uploadTask = image_path.putFile(mainImageURI);

                uploadTask.continueWithTask(new Continuation<UploadTask.TaskSnapshot, Task<Uri>>() {
                    @Override
                    public Task<Uri> then(@NonNull Task<UploadTask.TaskSnapshot> task) throws Exception {
                        if(!task.isSuccessful()){
                            throw task.getException();
                        }
                        return image_path.getDownloadUrl();
                    }
                }).addOnCompleteListener(new OnCompleteListener<Uri>() {
                    @Override
                    public void onComplete(@NonNull Task<Uri> task) {
                        if (task.isSuccessful()){
                            Uri downloadUrl = task.getResult();
                            Log.i("The URL : ", downloadUrl.toString());
                        }
                    }
                });
            }
        }
    });

score 0 · Answer 7 · edited Apr 28 '20 at 06:40

0

Try

{
    firebase.storage()
    .child()
    .getDownloadURL().then()
}

edited Apr 28 '20 at 06:40

David Buck

3,752
35
31
35

answered Apr 28 '20 at 05:01

Bliss Minengibi Ogbanga

1

Firebase Storage getDownloadUrl() method can't be resolved

7 Answers7

Linked

Related