jQuery/Javascript removing an object from array of objects

Question

I have an array of objects which looks like this:

[
[0]{"asin": "1234",
    "title: "Test"},
[1] {"asin": "123fef4",
    "title: "aaaaaaa"},
[2] {"asin": "testtet",
     "title: "testt123"},
]

Adding the items to the array works like a charm and here is the code:

 items.push(
 {
   "asin": "1234",
   "title": "test"
 });

This part works okay... Now here comes the part where I need to remove the items frmo the array by ASIN property inside of it...

I have a function which looks like this:

  function remove(array, element) {
            const index = array.indexOf(element);
            array.splice(index, 1);
            console.log("Removed element: " + element);
        }

How I call the remove function:

  remove(items, "1234");

This removes the item from the list, but not the one that I want.. I checked when I pass value 1234, the item with asin value 1234 stays in the array...

What could be wrong here ? :/

Cause an object does not match a string?!?!? – Jonas Wilms Jun 04 '18 at 16:17 — Jonas Wilms, Jun 04 '18 at 16:17
@JonasW. Ok got it but how can I fix it ? :) – User987 Jun 04 '18 at 16:18 — User987, Jun 04 '18 at 16:18

score 1 · Accepted Answer · answered Jun 04 '18 at 16:18

You can't match a string against an object. Use findIndex like below and use the returned index.

function remove(array, element) {
    const index = array.findIndex(e => e.asin === element);
    array.splice(index, 1);
    console.log("Removed element: " + element);
}

score 0 · Answer 2 · answered Jun 04 '18 at 16:19

You may wanna extend your removal function to:

function remove(array, key, value) {
  const index = array.findIndex(el => (el[key] || el) === value);
        array.splice(index, 1);
        console.log("Removed: " + index);
}

So you can do

remove(items, "asin", "1234");

score 0 · Answer 3 · answered Jun 04 '18 at 16:19

Try the following:

var arr =[
{"asin": "1234",
"title": "Test"},
{"asin": "123fef4",
"title": "aaaaaaa"},
{"asin": "testtet",
"title": "testt123"},
];

function remove(arr, val){
  var index = arr.findIndex((o)=> o.asin === val);
  if(index != 1)
    arr.splice(index, 1);
}
remove(arr, "1234");
console.log(arr);

jQuery/Javascript removing an object from array of objects

3 Answers3