.setText using SharedPreferences doesnt work

Question

I came here with another problem, this time it concerns Android app.

I've made an app with Login activity (no NavigationView) which move us after login to Home activity where is NavigationView. User data is saved in SharedPreferences, I'm using Constants class. My problem is that I can't setText on Home activity using SharedPreferences, but it working on Login activity (email address is inserted in EditText). Here is my code:

Login.java

package com.example.appname;

import android.app.Fragment;
import android.app.FragmentTransaction;
import android.content.Intent;
import android.content.SharedPreferences;
import android.graphics.Color;
import android.support.design.widget.CoordinatorLayout;
import android.support.design.widget.Snackbar;
import android.support.v7.app.AppCompatActivity;
import android.os.Bundle;
import android.support.v7.widget.AppCompatButton;
import android.util.Log;
import android.view.View;
import android.widget.EditText;
import android.widget.ProgressBar;
import android.widget.TextView;

import com.example.appname.models.ServerRequest;
import com.example.appname.models.ServerResponse;
import com.example.appname.models.User;

import retrofit2.Call;
import retrofit2.Callback;
import retrofit2.Retrofit;
import retrofit2.converter.gson.GsonConverterFactory;

public class Login extends AppCompatActivity {


private CoordinatorLayout coordinatorLayout;

private AppCompatButton btn_login;
private EditText et_email,et_password;
private TextView tv_register;
private ProgressBar progress;
private SharedPreferences pref;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_login);

    coordinatorLayout = (CoordinatorLayout) findViewById(R.id.coordinatorLayout);

    pref = getPreferences(0);


    btn_login = (AppCompatButton)findViewById(R.id.btn_login);
    tv_register = (TextView)findViewById(R.id.tv_register);
    et_email = (EditText)findViewById(R.id.et_email);
    et_email.setText(pref.getString(Constants.EMAIL, ""));
    et_password = (EditText)findViewById(R.id.et_password);

    progress = (ProgressBar)findViewById(R.id.progress);

    btn_login.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View view) {
            String email = et_email.getText().toString();
            String password = et_password.getText().toString();

            if(!email.isEmpty() && !password.isEmpty()) {

                progress.setVisibility(View.VISIBLE);
                loginProcess(email,password);

            } else {

                Snackbar snackbar = Snackbar
                        .make(coordinatorLayout, R.string.empty_fields, Snackbar.LENGTH_LONG);

                View sbView = snackbar.getView();
                TextView textView = (TextView) sbView.findViewById(android.support.design.R.id.snackbar_text);
                textView.setTextColor(Color.GREEN);
                snackbar.show();
            }
        }

    });

    tv_register.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View view) {

            Intent intent = new Intent(getApplicationContext(), Register.class);

            startActivity(intent);
            finish();
        }
    });


}






private void loginProcess(String email,String password){

    Retrofit retrofit = new Retrofit.Builder()
            .baseUrl(Constants.BASE_URL)
            .addConverterFactory(GsonConverterFactory.create())
            .build();

    RequestInterface requestInterface = retrofit.create(RequestInterface.class);

    User user = new User();
    user.setEmail(email);
    user.setPassword(password);
    ServerRequest request = new ServerRequest();
    request.setOperation(Constants.LOGIN_OPERATION);
    request.setUser(user);
    Call<ServerResponse> response = requestInterface.operation(request);

    response.enqueue(new Callback<ServerResponse>() {
        @Override
        public void onResponse(Call<ServerResponse> call, retrofit2.Response<ServerResponse> response) {

            ServerResponse resp = response.body();
            Snackbar.make(coordinatorLayout, resp.getMessage(), Snackbar.LENGTH_LONG).show();

            if(resp.getResult().equals(Constants.SUCCESS)){
                SharedPreferences.Editor editor = pref.edit();
                editor.putBoolean(Constants.IS_LOGGED_IN,true);
                editor.putString(Constants.EMAIL,resp.getUser().getEmail());
                editor.putString(Constants.NAME,resp.getUser().getName());
                editor.putString(Constants.UNIQUE_ID,resp.getUser().getUnique_id());
                editor.putString(Constants.POINTS,resp.getUser().getPoints());
                editor.apply();
                goToHome();

            }
            progress.setVisibility(View.INVISIBLE);
        }

        @Override
        public void onFailure(Call<ServerResponse> call, Throwable t) {

            progress.setVisibility(View.INVISIBLE);
            Log.d(Constants.TAG,"failed");
            Snackbar.make(coordinatorLayout, t.getLocalizedMessage(), Snackbar.LENGTH_LONG).show();

        }
    });
}



private void goToHome(){

    Intent intent = new Intent(getApplicationContext(), Home.class);

    startActivity(intent);
}
}

Home.java

package com.examle.appname;

import android.app.ActivityOptions;
import android.content.Intent;
import android.content.SharedPreferences;
import android.os.Bundle;
import android.support.design.internal.NavigationMenuPresenter;
import android.support.design.widget.FloatingActionButton;
import android.support.design.widget.NavigationView;
import android.support.design.widget.Snackbar;
import android.support.v4.view.GravityCompat;
import android.support.v4.widget.DrawerLayout;
import android.support.v7.app.ActionBarDrawerToggle;
import android.support.v7.app.AppCompatActivity;
import android.support.v7.widget.Toolbar;
import android.view.Menu;
import android.view.View;
import android.view.MenuItem;
import android.widget.TextView;
import android.widget.Toast;

public class Home extends AppCompatActivity implements 
NavigationView.OnNavigationItemSelectedListener {
private DrawerLayout drawerLayout;
private Toolbar toolbar;
private SharedPreferences pref;
private TextView tvname, tvpoints;

@Override
public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_home);

    pref = getPreferences(0);

    Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
    setSupportActionBar(toolbar);

    tvname = (TextView)findViewById(R.id.tv_name);
    tvpoints = (TextView)findViewById(R.id.tv_points);
    tvname.setText(pref.getString(Constants.NAME, ""));
    tvpoints.setText(pref.getString(Constants.POINTS, "") +R.string.act_points);



    DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
    ActionBarDrawerToggle toggle = new ActionBarDrawerToggle(
            this, drawer, toolbar, R.string.drawer_open, R.string.drawer_close);
    drawer.setDrawerListener(toggle);
    toggle.syncState();

    NavigationView navigationView = (NavigationView) findViewById(R.id.nvView);
    navigationView.setNavigationItemSelectedListener((NavigationView.OnNavigationItemSelectedListener) this);
    View headerView = navigationView.getHeaderView(0);
    TextView tvemail = (TextView) headerView.findViewById(R.id.tv_email);
    tvemail.setText(pref.getString(Constants.EMAIL, ""));

}

@Override
public void onBackPressed() {
    DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
    if (drawer.isDrawerOpen(GravityCompat.START)) {
        drawer.closeDrawer(GravityCompat.START);
    } else {
        super.onBackPressed();
    }
}

@Override
public boolean onCreateOptionsMenu(Menu menu) {
    getMenuInflater().inflate(R.menu.main, menu);
    return true;
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {

    int id = item.getItemId();     
    if (id == R.id.action_settings) {
        return true;
    }

    return super.onOptionsItemSelected(item);
}

@SuppressWarnings("StatementWithEmptyBody")


public boolean onNavigationItemSelected(MenuItem item) {

    int id=item.getItemId();
    switch (id){

        case R.id.navigation_home:
            Intent h= new Intent(Home.this,Home.class);
            startActivity(h);
            break;
        case R.id.navigation_showall:
            Intent i= new Intent(Home.this,ShowAllUsers.class);
            startActivity(i);
            break;
        case R.id.navigation_about:
            Intent g= new Intent(Home.this,About.class);
            startActivity(g);
            break;
        case R.id.navigation_settings:
            Intent s= new Intent(Home.this,AccountSettings.class);
            startActivity(s);
        case R.id.navigation_support:
            Intent t= new Intent(Home.this,Support.class);
            startActivity(t);
            break;
    }



    DrawerLayout drawer = (DrawerLayout) findViewById(R.id.drawer_layout);
    drawer.closeDrawer(GravityCompat.START);
    return true;
}
}

`package com.examle.appname;` in `Home.java` spells "example" wrong. — Ken Y-N, Jun 05 '18 at 08:42
How exactly does it not work? Do you see any errors in the LogCat? — Ken Y-N, Jun 05 '18 at 08:43
try the solution provided by the most upvoted response : https://stackoverflow.com/questions/12074156/android-storing-retrieving-strings-with-shared-preferences — user 007, Jun 05 '18 at 08:57

score 0 · Answer 1 · answered Jun 05 '18 at 08:58

0

Use getSharedPreferences instead of this getPreferences

answered Jun 05 '18 at 08:58

Parth Suthar

123
4

okay, but why getPreferences working on Login activity and its not working on Home? – Master Jun 05 '18 at 09:01
I think getPreferences is only for one activity. So better you need to use getSharedPreferences. – Parth Suthar Jun 05 '18 at 09:17

score 0 · Accepted Answer · answered Jun 05 '18 at 09:11

0

Try this way

 SharedPreferences sharedpreferences = getSharedPreferences(MyPREFERENCES, Context.MODE_PRIVATE);
    if (sharedpreferences.contains(Constants.NAME)) 
    {
        tvname.setText(sharedpreferences.getString(Constants.NAME, ""));
    }

answered Jun 05 '18 at 09:11

ajay dhadhal

306
4
16

score 0 · Answer 3 · answered Jun 05 '18 at 09:18

0

Because you are using two different instance of the SharedPreference in different activity use single instance. for more info check - https://stackoverflow.com/a/11567825/3912847

answered Jun 05 '18 at 09:18

Chandra Sharma

1,339
1
12
26

.setText using SharedPreferences doesnt work

3 Answers3