1

I am trying to create a series of folders and subfolders using python, but I just can't get it right. I keep getting an error where the folder of the folder I am currently in is being created in that same folder. I can't figure out how to get it straight.

import os, sys, errno

all_dirs = {
    'audio': ['Music', 'Audiobooks', 'Podcasts'],
    'documents': ['Forms', 'Bills', 'Legal', 'Financial'],
    'images': ['Photographs','Art', 'Friends', 'Family'],
    'literature': ['Novels', 'Poetry', 'Short Stories'],
    'software': ['Apps', 'Games'],
    'videos': ['TV Series', 'Movies', 'Documentaries']
}

def create_dirr(curr_dirr, dirs_to_create):
  if not os.path.exists(curr_dirr):
    try:
      os.makedirs(curr_dirr)
    except OSError as exc:  # Guard against race condition
      if exc.errno != errno.EEXIST:
        raise
  else:
    print 2, os.getcwd()
    for dirr in dirs_to_create:
      print 2.5, dirr, os.getcwd()
      os.path.join(os.getcwd(), curr_dirr)
      print 2.7, os.getcwd(), os.path.join(os.getcwd(), dirr)
      os.chdir(os.path.join(os.getcwd(), curr_dirr))
      # os.path.join(ff, dirr)
      print 2.8, os.getcwd()
      # os.makedirs(dirr)
      # os.chdir(os.path.join(os.getcwd(), curr_dirr))
      print 2.9, dirr, os.getcwd()
      vv = os.path.join(os.getcwd(), dirr)
      print 3, dirr, os.getcwd()
      print 4, os.path.exists(dirr)
      print 5, vv
      print 7, dirr, os.getcwd()
      print '------------------------------------'
      if not os.path.exists(vv):
        print "here"
        try:
          print 6, vv
          # os.makedirs(vv)
        except OSError as exc:  # Guard against race condition
          if exc.errno != errno.EEXIST:
            raise
for x in all_dirs:
  create_dirr(x, all_dirs[x])
  create_dirr(x, all_dirs[x])

Here is the output and error code:

2 /home/runner
2.5 Forms /home/runner
2.7 /home/runner /home/runner/Forms
2.8 /home/runner/documents
2.9 Forms /home/runner/documents
3 Forms /home/runner/documents
4 False
5 /home/runner/documents/Forms
7 Forms /home/runner/documents
------------------------------------
here
6 /home/runner/documents/Forms
2.5 Bills /home/runner/documents
2.7 /home/runner/documents /home/runner/documents/Bills
Traceback (most recent call last):
  File "python", line 130, in <module>
  File "python", line 104, in create_dirr
OSError: [Errno 2] No such file or directory: '/home/runner/documents/documents'
Jeff Mercado
  • 129,526
  • 32
  • 251
  • 272
user2986242
  • 477
  • 1
  • 5
  • 19
  • You need to put a `/` after the `'/home/runner/documents/documents'` mentioned in the error as currently, it's referring to a file of an unknown type which doesn't exist. – Adi219 Jun 07 '18 at 21:24
  • Using `pathlib.Path` all those `os.join` calls become simply `parent_path / sub_name` - but you'll have to upgrade to Python 3.5 to get the best bits... – PaulMcG Jun 07 '18 at 21:25

2 Answers2

0

when you make os.chdir you have not create the child folder yet. Easy fix

before make os.chdir make:

os.makedirs(os.path.join(os.getcwd(), curr_dirr), exist_ok=True)
0

I figured it out.

First, I created a variable for os.getcwd() before the loop. Then, I combined it in os.path.join with curr_dirr and dirr. I also removed os.chdir().

Result:

def create_dirr(curr_dirr, dirs_to_create):
  if not os.path.exists(curr_dirr):
    try:
      os.makedirs(curr_dirr)
    except OSError as exc:  # Guard against race condition
      if exc.errno != errno.EEXIST:
        raise
  else:
    print 2, os.getcwd()
    cd = os.getcwd()
    for dirr in dirs_to_create:
      print 2.5, dirr, os.getcwd(), os.path.join(cd, curr_dirr)
      print 2.7, os.path.join(cd, curr_dirr, dirr)
      print 2.8, cd
      print 3, dirr, cd
      print '------------------------------------'
      if not os.path.exists(os.path.join(cd, curr_dirr, dirr)):
        print "here"
        try:
          print 6, os.path.join(cd, curr_dirr, dirr)
          os.makedirs(os.path.join(cd, curr_dirr, dirr))
        except OSError as exc:  # Guard against race condition
          if exc.errno != errno.EEXIST:
            raise

Using this snippet to layout the file structure, I was able to see it work.

for root, dirs, files in os.walk("."):
    path = root.split(os.sep)
    print((len(path) - 1) * '---', os.path.basename(root))
    for file in files:
        print(len(path) * '---', file)
user2986242
  • 477
  • 1
  • 5
  • 19