Service already running while it shouldnt in Location Using Background Service code

Question

I am having an app that has to get the location of where I am in many activities. I found this very helpful complete piece of code here. Its how to Get Current Location Using Background Service. I implemented it in my code. The first time it worked ok. The next, when it reached this if

if (mPref.getString("service", "").matches("")) {
        medit.putString("service", "service").commit();
        Intent intent = new Intent(getApplicationContext(), GoogleService.class);
        startService(intent);

 } else {
        Toast.makeText(getApplicationContext(), "Service is already running", Toast.LENGTH_SHORT).show();
  }

I get the message that service is already running. Why this happens? I have closed and reopened the app, why the service still running? Help pls, its very important, thank you

`if (mPref.getString("service", "").matches("")) {` ..where are u setting this — Psypher, Jun 16 '18 at 19:10
@psypher If you see the code on the link I use it like that exactly. I'm setting it in onCreate of the activity — ProgrammerToBe, Jun 16 '18 at 19:14
Possible duplicate of [How to check if a service is running on Android?](https://stackoverflow.com/questions/600207/how-to-check-if-a-service-is-running-on-android) — Todd Sewell, Jun 16 '18 at 19:15
I close it from the screen where you can see the standby apps, like a user would do — ProgrammerToBe, Jun 16 '18 at 19:17

Anatolii · Accepted Answer · 2018-06-16T20:40:17.927

0

If you use SharedPreferences to persist the info about your Service then the info survives the app restart and so your if condition is always false (when you do mPref.commit() you save the key pair to the file).

edited Jun 16 '18 at 20:40

answered Jun 16 '18 at 19:17

Anatolii

14,139
4
35
65

So I shouldnt use that? What should I use instead? – ProgrammerToBe Jun 16 '18 at 19:18
@ProgrammerToBe If the service is running then your startService() won't create a new service but only invoke onStartCommand of the existing one. – Anatolii Jun 16 '18 at 19:21
@ProgrammerToBe why are you doing this check anyways? Then, I could suggest what to do instead. – Anatolii Jun 17 '18 at 19:02
Yes you are right, I just removed it and it works, thank you very much – ProgrammerToBe Jun 18 '18 at 00:34

Service already running while it shouldnt in Location Using Background Service code

1 Answers1