getDrawable (int) in Context cannot be applied to (java.lang.String)

Question

Here's the code:

String id = "R.drwable.br" + mQuestionNumber;
mSlikaNastavi.setImageDrawable(getDrawable(id));

error found on getDrawable(id): getDrawable (int) in Context cannot be applied to (java.lang.String)

mSlikaNstavi is ImageView, and I would like to change image from java. I cant write in R.drawable.br2 in getDrwable() because every time mQuestionNumber is different.

Sagar · Answer 1 · 2018-06-18T08:17:51.587

1

A drawable Id needs to be int rather than String. You can get the relative int Id using getIdentifier()

Instead of

mSlikaNastavi.setImageDrawable(getDrawable(id))

Use

String id = "br" + mQuestionNumber;
mSlikaNastavi.setImageDrawable(getDrawable(getResources().getIdentifier(id, "drawable", getPackageName())));`

edited Jun 18 '18 at 08:17

answered Jun 18 '18 at 07:57

Sagar

23,903
4
62
62

Thank you for your answer, but: https://imgur.com/a/aumHnRe – Jun 18 '18 at 08:01
@Manuelbradičić check the updated the answer – Sagar Jun 18 '18 at 08:04
Android app is crashing when it comes on this part of code. When I comment this part of code it does not. – Jun 18 '18 at 08:09
@Manuelbradičić spelling of drawable was incorrect. check the udpated answer – Sagar Jun 18 '18 at 08:10
`String id = "R.drawable.br" + mQuestionNumber;` should be `String id = "br" + mQuestionNumber;` – Blackbelt Jun 18 '18 at 08:11

score 1 · Accepted Answer · answered Jun 18 '18 at 08:09

I guess you have drawables like br1, br2, br3,... and you think that by concatenating R.drawable.br and mQuestionNumber you get the id of the drawable but this is not the case.

do this:

int id = getResources().getIdentifier("br" + mQuestionNumber, "drawable", getPackageName());
mSlikaNastavi.setImageDrawable(getDrawable(id));

Anmol · Answer 3 · 2018-06-18T08:15:35.617

Here you need to extract the Drawable Id by passing your own id value, instead of the ids which are present in R.java

So for that getIdentifier method is used where you need to provide the drawable name, type of the resource which is "drawable" in your case, and the packageName where Android will search the drawable from.

    int drawableId = getResources().getIdentifier("br" + mQuestionNumber,"drawable",getPackageName());

After the id is found, use it to show it in imageView using setImageDrawable() and as it required Drawable get the Drawabel from its iD using getDrawable() passing in the ID.

    mSlikaNastavi.setImageDrawable(getResources().getDrawable(drawableId));

So the code is:

    int drawableId = getResources().getIdentifier("br" + mQuestionNumber,"drawable",getPackageName());
    mSlikaNastavi.setImageDrawable(getResources().getDrawable(drawableId));

getDrawable (int) in Context cannot be applied to (java.lang.String)

3 Answers3