request-promise always returns response instead of returned value

Question

I want to pass a variable defined inside request-promise to a variable out of scope. I thought I may pass the variable using a return statement inside the request function, but the request function always returns the http response (in this case as HTML output).

My code:

require('dotenv').config();
const jsdom = require("jsdom");
const { JSDOM } = jsdom;
var request = require('request-promise');

var get = function(arg1, arg2, arg3, arg4) {
    request(`https://www.googleapis.com/customsearch/v1?key=${process.env.API_KEY}&cx=${process.env.CX}&q=${arg1}`, async function(err, res, body) {
        var obj = JSON.parse(body);
        var url =  obj.items[0].formattedUrl;
        var part = await request(`${url}/staffel-${arg2}/episode-${arg3}`, function(err, res, body) {
            const dom = new JSDOM(`${body}`);
            var part = dom.window.document.getElementsByClassName(arg4)[0];
            return part;
        });
        console.log(part);
    });
};

Furthermore, I'd like to pass the output to the get-function using return statements. Is there any way to do so?

Edit: From my point of view, this is not a duplicate of this question. The request returns a value, but it's not the value I want to return as explained above.

Possible duplicate of [How do I return the response from an asynchronous call?](https://stackoverflow.com/questions/14220321/how-do-i-return-the-response-from-an-asynchronous-call) — Patrick Hund, Jun 25 '18 at 15:49
I don't think so: The function returns a value, but indeed not the value I'd like it to return. — A. Dro. ID, Jun 25 '18 at 15:58

SAGAR RAVAL · Answer 1 · 2018-06-25T16:51:21.473

I guess your implementation is not perfect for request-promise with async await. didn't run the code but try below one.

async function asyncCall(arg1, arg2, arg3, arg4){
    try{
        var first = await request(`https://www.googleapis.com/customsearch/v1?key=${process.env.API_KEY}&cx=${process.env.CX}&q=${arg1}`);
        if(typeof first.body === "string"){
            first.body = JSON.parse(first.body);
        }
        var obj = first.body;
        var url =  obj.items[0].formattedUrl;
        var part = await request(`${url}/staffel-${arg2}/episode-${arg3}`)
        if(typeof part.body === "string"){
            part.body = JSON.parse(part.body);
        }
        var dom = new JSDOM(`${JSON.parse(part.body)}`)
        return dom.window.document.getElementsByClassName(arg4)[0];
    }
    catch(e){
        console.log(e);
    }
}

Looks a lot cleaner, but returns: https://pastebin.com/raw/SbfTLBV8 Position 33 is `var obj = JSON.parse(first.body);` — A. Dro. ID, Jun 25 '18 at 16:19
I guess the response from the server you are getting is already an object. Check the updated code. — SAGAR RAVAL, Jun 25 '18 at 16:53

request-promise always returns response instead of returned value

1 Answers1