I'm trying to add values into database, but every time I try to add some thing i get an error 'Connection must be valid and open.'

Question

This is the error I'm getting:

with this code:

private void button1_Click_1(object sender, EventArgs e)
{
    if (txtID.Text == "" || txtName.Text == "" || txtMobileNo.Text == "")
    {
        MessageBox.Show("Please Enter all of your detail.", "Stop", MessageBoxButtons.OK, MessageBoxIcon.Stop);
    }
    else
    {
        string query = "INSERT INTO tablemm (id,Name,MobileNo) VALUES ('" + txtID.Text + "','" + txtName.Text + "','" + txtMobileNo.Text + "')";

        OpenConnection();

        MySqlCommand ObjCommand = new MySqlCommand(query, ObjConnection);
        ObjCommand.ExecuteNonQuery();

        this.CloseConnection();
    }
}

[SQL-Injection](https://en.wikipedia.org/wiki/SQL_injection) Alert! — Salah Akbari, Jun 30 '18 at 07:37
post the full code! ObjConnection and OpenConnection() method code — Prashant Pimpale, Jun 30 '18 at 07:37
Also don't link pictures, it makes us click and we hate clicking — TheGeneral, Jun 30 '18 at 07:41
//Global variable private MySqlConnection ObjConnection; private string server, database, uid, password; //intialize connection private void InitializeConnection() { server = "localhost"; database = "table"; uid = "root"; password = ""; string connectionString = "SERVER=" + server + ";" + "DATABASE=" + database + ";" + "UID=" + uid + ";" + "PASSWORD=" + password + ";"; ObjConnection = new MySqlConnection(connectionString); } — efaisalzia, Jun 30 '18 at 08:25
private bool OpenConnection() { try { ObjConnection.Open(); return true; } catch (MySqlException ex) { switch (ex.Number) { case 0: MessageBox.Show("Can not connect to server"); break; case 1045: MessageBox.Show("Invalid User name/Password"); break; } return false; } } — efaisalzia, Jun 30 '18 at 08:28

score 1 · Accepted Answer · edited Jun 30 '18 at 08:01

1

You have probably forgotten to call Open

MySqlCommand myCommand = new MySqlCommand(myExecuteQuery, myConnection);
myCommand.Connection.Open();  // wallah 
myCommand.ExecuteNonQuery();
myConnection.Close();

Also use a using statement where possible,

Disclaimer: This is only for demonstration purposes and I can't be held responsible for the people you maim and otherwise hurt with this code

edited Jun 30 '18 at 08:01

Aleks Andreev

7,016
8
29
37

answered Jun 30 '18 at 07:34

TheGeneral

79,002
9
103
141

1

How do you know, he/she hasn't called `Open` in the `OpenConnection();` method? – Salah Akbari Jun 30 '18 at 07:36
yeah he was right actually ,but now another problem Popup – efaisalzia Jun 30 '18 at 08:36
MySql.Data.MySqlClient.MySqlException: 'The host localhost does not support SSL connections.' – efaisalzia Jun 30 '18 at 08:36
@imzia99 this is basically another question though this might help you https://stackoverflow.com/questions/45086283/mysql-data-mysqlclient-mysqlexception-the-host-localhost-does-not-support-ssl – TheGeneral Jun 30 '18 at 08:38

score -1 · Answer 2 · answered Jun 30 '18 at 07:37

-1

I believe that your INSERT statement should be after you open your connection with the database and right before you close it.

answered Jun 30 '18 at 07:37

jam

1
2

Are you serious? – Prashant Pimpale Jun 30 '18 at 07:38
yes it is after the Open Connection ,it is in the end actually – efaisalzia Jun 30 '18 at 08:33

I'm trying to add values into database, but every time I try to add some thing i get an error 'Connection must be valid and open.'

2 Answers2