Running ESLint in precommit does not stop on warnings

Question

I'm adding some precommit and prepush scripts to my project. I'm using Husky because it keeps tracked on git any change.

On my package.json I have:

"precommit": "npm run lint && npm run test",

Which initially seems to be working fine, when any test or lint error was found I was unable to make the commit.

Now I found that if I have a warning, the commit happens anyway.

How can I configure Husky, or maybe ESLint, to stop the commit when there are warnings?

I know I could override all eslint configs to be always error [2], but I'm expecting there is something better

Oleg Vikoultsev · Accepted Answer · 2021-11-07T11:45:59.673

63

You need specify --max-warnings param.

Something like this:

"scripts": {
  ...
  "lint": "eslint \"**/*.js\" --max-warnings=0",
  ...
},

edited Nov 07 '21 at 11:45

answered Oct 19 '18 at 16:16

Oleg Vikoultsev

very nice. saves time. – Mehadi Hassan Jul 13 '20 at 08:42
14

I would recommend **not** running `--fix` in a pre-commit scenario, because if it fixes something the linting will pass but those fixes will be unstaged (and therefore won't be included in the commit). – jonrsharpe Sep 16 '20 at 12:13
2

@jonrsharpe Not if you use lint-staged – Yohan Dahmani Jul 13 '21 at 09:54

score 0 · Answer 2 · answered Jul 06 '22 at 09:29

0

"eslint --cache --max-warnings=-1" ignore all eslint warnings

answered Jul 06 '22 at 09:29

spstar

2 Answers2