PHP- Redirect to another page

Question

My question is very simple. but I am struggling with it too much. The problem is once I hit the submit button that page should redirect to some other page. Kindly just tell me what I have done wrong? Because I have tried everything.

Code:

Update-docket.php

<?php
//error_reporting(0);
$link = mysqli_connect("localhost", "home_db", "root", "");

// Check connection 
if($link === false){
    die("ERROR: Could not connect. " . mysqli_connect_error());
}

// Escape user inputs for security
$sql = 'SELECT * FROM prod_details';
$result = mysqli_query($link,$sql);

while ($row = mysqli_fetch_array($result))
{ 
     $Quantity1 = $_POST['p_'.$row['id']. ''];          
     $id = $row['id'];
     $store = $row['rstore'];
     // echo $store;

     foreach ($_POST as $key => $value) 
     {}

     if(!empty($Quantity1)) {
         $query="update prod_details SET rdocket='$Quantity1' WHERE id='$id'";
         if(mysqli_query($link, $query)) {
            header('Location: /docket-details.php');
            exit();
         } else {
            echo "ERROR: Could not able to execute $sql. " . mysqli_error($link);
         }
      }
  }

docket-details.php

<form class="form-horizontal" action="update-docket.php" method="post" name="myform" autocomplete="off">
  <button  type='submit'  name='submit' class='btn c-theme-btn c-btn-square c-btn-uppercase c-btn-bold'>Submit</button>

Please help!!!

Answer 1

You're Location line is incorrect, redirect using:

header('Location: /url');

https://secure.php.net/manual/en/function.header.php

update

I reckon your if statement is not being met. Try enabling error logging again and var_dumping inside each conditional section to see where the real problem lies. Now you've updated your code to use header it should in theory work. But my guess is $_POST not returning what you want/expect.

Answer 2

Edited!

Try this:

header('Location: /docket-details.php');
// i'm sorry, forgot to add exit
exit();

of course you can fill the full url if you refer.

Important: No output should be made before this line as it will generate a header. Not a single echo before sending the response header!

Answer 3

It should be something like that:

if(!empty($Quantity1)) {
    $query="update prod_details SET rdocket='$Quantity1' WHERE id='$id'";
    $res = mysqli_query($link, $query);

    if($res) {
        header('Location: /docket-details.php', true, '200');
    } else {
        echo "ERROR: Could not able to execute $sql. " . mysqli_error($link);
    }
}

Answer 4

you have "update-details.php" but you reference "update-docket.php" in your form action. So the form action redirects to a different file.

As stated by @thisGuyHasTwoThumbs your Location line is incorrect.

header('Location: /url');
exit();

You also want to exit() as it will prevent any execution of code after that line.

https://secure.php.net/manual/en/function.header.php https://secure.php.net/manual/en/function.exit.php

Jus for the details:

"update prod_details SET rdocket='$Quantity1' WHERE id='$id'"

Wil look much cleaner and is easier to read like:

"UPDATE `prod_details` SET `rdocket` = '$Quantity1' WHERE `id` ='$id'"

Keeps MySQL words in capital. Wrap column and table names in backticks will prevent "MySQL serverd word error"

Making it:

<form class="form-horizontal" action="update-docket.php" method="post" name="myform" autocomplete="off">

<?php
if (!empty( $Quantity1) )
{
    $query = "UPDATE `prod_details` SET `rdocket` = '$Quantity1' WHERE `id` ='$id'";
    if( mysqli_query( $link, $query ) )
    {
        header( 'Location: /docket-details.php' );
        exit();
    } else {
        echo "ERROR: Could not able to execute $sql. " . mysqli_error($link);
    }
}

The variable $Quantity1 is open for SQL-injection. To resolve this you can escape the variable if it is a string but you should use prepared statement.

Answer 5

It's also best to not output anything before the header() .. eg; don't echo "ERROR: Could not able to execute $sql. " . mysqli_error($link);

Answer 6

It seems your file is named "Update-docket.php", with a capital U. But in the action of the form you call for action="update-docket.php".

Answer 7

header(location:pagename with extension)

If the above code is not running properly and it give error that "header does not change" the put the below line on the top of the page and bottom of the page respectively

ob_start() - on the top of the page ob_end_flush() - bottom of the page