Update multiple elements in an array in mongodb

Question

I have a document like following in my stocks collection in mongodb.

{ _id: 'xRMuRBhqRLgASyQyW',
  History: 
     [ { orderId: '12032017001877',
         status: 'COMPLETED',
        },
       { orderId: '22122017002450', 
        status: 'PROCESSED',
        },
        { orderId: '22122018002450', 
        status: 'DEPOSIT',
        }  
     ] 
 }

I want to iterate through all document in stocks collection and add a field flag: true if status is not 'PROCESSED'.

If there's just one such sub-document in every array, you can use mongodb positional operator $. if several, then most likely you'll have to read the document, change its contents on the client, and save back (possibly as a series of surgical `$set` commands, like `$set: {'History.2.flag': 'true'}`) — Sergio Tulentsev, Jul 06 '18 at 09:18
Sergio Tulentsev , sir Are you talking about the History Array ? No there is many item in that array. And I am trying to change my database using mongo shell so there is no client side. — Mritunjay Upadhyay, Jul 06 '18 at 09:23
But that's a gui, not a shell. Anyway, shell is a client too. Everything is a client, except the database itself. — Sergio Tulentsev, Jul 06 '18 at 09:32
@SergioTulentsev `$[]` the all positional operator will work for multiple documents as well... — Ashh, Jul 06 '18 at 11:07
@AnthonyWinzlet: ooh, that's a new one (to me). Thanks, TIL. — Sergio Tulentsev, Jul 06 '18 at 11:07

Ashh · Answer 1 · 2018-07-06T12:02:59.570

14

You need to use the all $[] positional operator to update each element in the array

db.collection.update(
   { "History": { "$elemMatch": { "status": { "$ne": "PROCESSED" } } } }, 
   { "$set": { "History.$[].flag": false } },
   { "multi": true }
)

edited Jul 06 '18 at 12:02

answered Jul 06 '18 at 10:24

Ashh

44,693
14
105
132

2

Sir, it is a nice one but I think two extra parameters(basically false and true as they are suitable here for me) should be added for 'upsert' and 'multi'. Here I am writing because of 'multi' so that it could change more than one documents. – Mritunjay Upadhyay Jul 06 '18 at 11:22
You can use `multi` true for multiple documents but don't know why `upsert`here? – Ashh Jul 06 '18 at 11:51
Sir Using 'upser' to false we can ensure that even if there is no any document to satisfy the criteria , a new document will not be created – Mritunjay Upadhyay Jul 06 '18 at 11:54
by default `upsert` is `false`... So there is no need to write it... But if you want to ensure then you can put it to `false` – Ashh Jul 06 '18 at 12:02
1

Bingo!! This is the perfect answer for an update each element in the array. – Harshal Yelpale Sep 11 '18 at 10:30
1

simply P E R F E C T – Bruno Morales Apr 15 '19 at 19:58

score 2 · Accepted Answer · edited Apr 24 '20 at 16:45

2

You can achieve it using script.

db.stocks.find().forEach(function (e) {
  var modified = false;
  e.History.forEach(function (o) {
    if (o.status != "PROCESSED") {
      o.flag = true;
      modified = true;
    }
  });
  if (modified) {
    db.stocks.save(e);
  }
});

edited Apr 24 '20 at 16:45

answered Jul 06 '18 at 10:28

Vikas

51
4

I found this is the best one. Most suitable to my problem – Mritunjay Upadhyay Jul 06 '18 at 16:23

score 1 · Answer 3 · answered Jul 06 '18 at 09:50

1

You can simply do it by using '$' operator. Something like:

 db.stocks.update( {"history.status" : { $not: "PROCESSED" } , 
                { $set: {"history.$.flag": true }} , 
                false , 
                true);

answered Jul 06 '18 at 09:50

Pouya Jabbarisani

1,084
3
16
29

1

Won't work for multiple matches in the same array. – Sergio Tulentsev Jul 06 '18 at 10:05

Mritunjay Upadhyay · Answer 4 · 2018-07-06T12:08:53.487

My answer is very similar @Anthony but a two extra parameter( for upsert and multi) are added. For reference You can check official document.

db.stocks.update(
    { "History": { "$elemMatch": { "status": { "$ne": "PROCESSED" } } } }, 
    { "$set": { "History.$[].flag": false }},
     false,              // show that if there is not any document with specified criteria , it will not create a new document.
     ture              // according to document of mongodb if multi is true then more than one document will be updated, other wise only one document will be updated.
)

Update multiple elements in an array in mongodb

4 Answers4

Linked

Related