FileUpload using Socket in java

Question

when i try upload file from client device to server using socket in java. it get uploaded in server but the problem is that when i tried to open it show some error.(for example:if i upload photos from client to server,it get uploaded but when i tried to open it show error "unsupported file format".

clientSide:

DataOutputStream dos = new DataOutputStream(tmp.getClientSocket().getOutputStream());
    BufferedInputStream fileReader=new BufferedInputStream(new FileInputStream(f));
    byte[] buffer = new byte[1024];
    int byteRead=0;
    while((byteRead=fileReader.read(buffer))!=-1) {
        dos.write(buffer,0,byteRead);
        dos.flush();
        System.out.println("uploading "+byteRead);
    }

    fileReader.close();


    System.out.println("uploading file completed");

serverSide:

String filename=this.input.readLine();
    System.out.println("file to be upload is "+filename);
    InputStream inputByte=socket.getInputStream();
    BufferedInputStream input=new BufferedInputStream(inputByte);

    String response=this.input.readLine();
    if(response.equals("start")) {

    BufferedOutputStream outputFile=new BufferedOutputStream(new FileOutputStream(projectDirPath+"\\"+filename));
    byte[] buffer =new byte[1024];
    int byteRead=0;

    while((byteRead=input.read(buffer))!=-1) {

        outputFile.write(buffer,0,byteRead);
        outputFile.flush();
        System.out.println("uploading "+byteRead);
    }
    outputFile.close();

    }else {
        System.out.println("nothing to upload");
    }

Is the file the correct size when it's uploaded? You also don't need to be calling `flush()` in the loops, it'll only make things slower. — Kayaman, Jul 06 '18 at 13:03
@Kayaman my this while loop doesnot ternminate.Please help while((n = dis.read(buf)) != -1 )){/* */} — Manjil Nepali, Jul 08 '18 at 14:54

Ravi S. · Accepted Answer · 2018-07-07T09:34:30.387

-2

client side:

    String path = "path";
    String fileName = "fileName.ext";
    try (Socket socket = new Socket("localhost", port)) {
        File file = new File(path, fileName);

        OutputStream os = socket.getOutputStream();
        BufferedOutputStream bos = new BufferedOutputStream(os);
        try (DataOutputStream dos = new DataOutputStream(bos)) {                
            FileInputStream fis = new FileInputStream(file);
            try (BufferedInputStream bis = new BufferedInputStream(fis)) {
                dos.write(IOUtils.toByteArray(bis));
            }
        }
    }
    catch(Exception e) {
        e.printStackTrace();
    }

Server Side:

try {
    ServerSocket serverSocket = new ServerSocket(port);
    Socket socket = serverSocket.accept();
    File tempFile = new File(path, fileName);
    InputStream is = socket.getInputStream();
    BufferedInputStream bis = new BufferedInputStream(is);
    try (DataInputStream dis = new DataInputStream(bis)) {
        FileOutputStream fos = new FileOutputStream(tempFile);
        try (BufferedOutputStream bos = new BufferedOutputStream(fos)) {
            bos.write(IOUtils.toByteArray(dis));
        }
    }
}
catch(Exception e) {
    e.printStackTrace();
}

edited Jul 07 '18 at 09:34

answered Jul 06 '18 at 14:28

Ravi S.

68
1
17

why i am getting socket closed error after uploading file – Manjil Nepali Jul 07 '18 at 07:02
remove `bos.flush()` and `bos.close()` statements from client and server side code. – Ravi S. Jul 07 '18 at 07:35
still getting socket closed error – Manjil Nepali Jul 07 '18 at 07:47
what is use of this line of code "DataInputStream dis = new DataInputStream(bis)"? we arenot use dis for any thing – Manjil Nepali Jul 07 '18 at 07:49
error remove after removing that line of code!! – Manjil Nepali Jul 07 '18 at 07:51
now, is it ok?? – Ravi S. Jul 07 '18 at 07:56
file appear in folder but its size is 0 kb – Manjil Nepali Jul 07 '18 at 07:58
I've edited the code. check it. – Ravi S. Jul 07 '18 at 09:35
The `DataInputStream` and `DataOutputStream` are both redundant here, and no explanation is provided. Mere code is not an answer. – user207421 Jul 07 '18 at 10:50
still gettting socket is close exception.Do you know why i am getting this error?? – Manjil Nepali Jul 07 '18 at 10:54

FileUpload using Socket in java

1 Answers1