SetText isn't working inside for loop

Question

Note: I searched google and here for few hours, but didn't get the answer.

I want to show the value what will for loop return. Here is my code:

mProgressBar = findViewById(R.id.progressBar);
        percentText = findViewById(R.id.percent);

        mProgressBar.setMax(100);
        mProgressBar.setProgress(0);

        new Thread(new Runnable() {
            @Override
            public void run() {
                try{
                    for (int progress = 0; progress<100; progress++){
                        mProgressBar.setProgress(progress);
                        percentText.setText(progress);
                        sleep(30);
                    }

                }catch (Exception e){
                    e.printStackTrace();
                }finally {
                    Intent intent = new Intent(SplashScreenActivity.this, SignUpLoginActivity.class);
                    startActivity(intent);
                }

App crashing while I'm adding this line percentText.setText(progress);. Without this line, code is working well. What should I do to show the progress value to the TextView?

Answer 1

Ok, so adding my input to all the issues raised in the various answers, this is a complete working example Activity. The main issues identified were 1) calling setText(int) rather than setText(String) and 2) updating UI elements off the UI thread.

import android.os.Bundle;
import android.os.Handler;
import android.support.v7.app.AppCompatActivity;
import android.widget.ProgressBar;
import android.widget.TextView;

public class MainActivity extends AppCompatActivity {

    private final Handler handler = new Handler();
    private TextView percentText;
    private ProgressBar mProgressBar;
    private int progress = 0;
    private final int updateFreqMs = 100; // call update every 100 ms

    @Override
    protected void onPause() {
        super.onPause();
        handler.removeCallbacksAndMessages(null);
    }

    @Override
    protected void onResume() {
        super.onResume();
        // reset the counter every time the activity resumes, whether 
        // you do this depends how you want it to behave
        progress = 0; 
        handler.postDelayed(new Runnable() {
            @Override
            public void run() {
                updateProgress();
                if( progress < 100 ) {
                    handler.postDelayed(this, updateFreqMs);
                }
                else {
                    // Didn't test this part, but this is where you'd launch
                    // the next activity after the progress is complete
                    Intent intent = new Intent(MainActivity.this, SignUpLoginActivity.class);
                    startActivity(intent);

                    // probably also want to finish this so the user can't
                    // press back and come back here
                    finish();
                }
            }
        }, updateFreqMs);
    }

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_your_layout); // Put your layout id here
        percentText = findViewById(R.id.percent);
        mProgressBar = findViewById(R.id.progressBar);

        mProgressBar.setMax(100);
        mProgressBar.setProgress(0);
    }

    private void updateProgress() {
        // this will be called until progress == 100
        ++progress;
        mProgressBar.setProgress(progress);
        percentText.setText(String.valueOf(progress));
    }
}

Answer 2

It doesn't look like you've started your thread...

try

new Thread(new Runnable() {...all your code...})).start()

Answer 3

You should use handler to set progress to textview inside your for loop

// Update the progress bar and display the
                //current value in the text view
                handler.post(new Runnable() {
                    public void run() {
                        progressBar.setProgress(progress);
                        textView.setText(progress);
                    }
                });

Answer 4

You have to update the UI on the UI thread, not on other thread. Use code something like this

Handler mainHandler = new Handler(Looper.getMainLooper());

Runnable myRunnable = new Runnable() {
    @Override 
    public void run() {
         percentText.setText(progress);
    } 
};
mainHandler.post(myRunnable);

Answer 5

You should run UI modifying codes in UI Thread.

U can access UI thread inside your thread like this:

new Thread(new Runnable() {
            @Override
            public void run() {
                yourActivity.runOnUiThread(new Runnable() {
                    @Override
                    public void run() {
                       percentText.setText(progress);
                    }
                });
            }

Answer 6

App crashing while I'm adding this line percentText.setText(progress);

Only UI Thread can access Views. You can't access any View from Background Thread. Use Handler to send task to UI Thread.

Handler mHandler = new Handler(Looper.getMainLooper());

 .............................

for (int progress = 0; progress<100; progress++){
   // mProgressBar.setProgress(progress);
   // percentText.setText(progress);
    mHandler.post(new Runnable() {
     @Override
     public void run() {
       // this will run in the main thread
       percentText.setText(progress);
       mProgressBar.setProgress(progress);
     }
     });
    sleep(30);

}

Answer 7

This is because the progress is of integer type. instead of

progressText.setText(progress);

which may result in resources not found exception.

use

progressText.setText(String.valueOf(progress));