Mongoose findOneAndUpdate: update an object in an array of objects

Question

I have the exact same issue as described in this thread (hence the similar title): Mongoose findOneAndUpdate -- updating an object inside an array of objects

Given this model:

const SavedFoodsSchema = new Schema({
  user: { type: Schema.Types.ObjectId, ref: 'User' },
  list: [
    {
      id: { type: Number, required: true, unique: true },
      name: { type: String, required: true },
      points: { type: Number, required: true }
    }
  ]
})

I wrote the following function just to test finding a document in the SavedFoods Collection based on the userId param, and then in the list array, for the first object in the array, setting the name to "Something else".

function updateFood (userId) {
  // This didn't work
  SavedFoods.findOneAndUpdate(
    {
      id: userId,
      'list.id': 0
    },
    {
      $set: {
        'list.$.name': 'Something else'
      }
    },
    null,
    (err) => {
      if (err) {
        console.log('Error:', err)
      } else {
        console.log('Updated', userId)
      }
      process.exit(0)
    }
  )
}

The callback is called and there is no error, however the the changes do not get reflected in my db.

Am I doing something wrong?

`id: userId` or `user: userId` is this ok? because your query seems to be ok... — Ashh, Jul 08 '18 at 04:00
@AnthonyWinzlet thank you so much! "id" was indeed incorrect, the field was actually "user" as you suggested - it now works perfectly. If you'd like to add this as an answer, I'll choose it as the accepted answer. — Liran H, Jul 08 '18 at 22:27

score 3 · Accepted Answer · answered Jul 08 '18 at 23:37

3

I think you mismatched id and user field

Try to change id with user

SavedFoods.findOneAndUpdate(
    {
      user: userId,
      'list.id': 0
    }
)

answered Jul 08 '18 at 23:37

Ashh

44,693
14
105
132

score 2 · Answer 2 · answered Jan 18 '20 at 00:50

I had the same problem, so I just delete $set from .findOneAndUpdate

Example:

function updateFood (userId) {
  SavedFoods.findOneAndUpdate(
    {
      id: userId,
      'list.id': 0
    },
    {
      {'list.$.name': 'Something else'}
    },
    null,
    (err) => {
      if (err) {
        console.log('Error:', err)
      } else {
        console.log('Updated', userId)
      }
      process.exit(0)
    }
  )
}

Works for me.

Mongoose findOneAndUpdate: update an object in an array of objects

2 Answers2

Linked