Python - operate a method

Question

A question from a beginner:

Can someone explain to me please why the method change_pos isn't working and doesn't change the sitting position from True to False (and either the opposite way) in the following code?
How do I implement this change_pos method to whole instances (p1, p2) in one line of code?

class Person:
    def __init__(self, name, Personality, isSitting):
        self.name=name
        self.Personality = Personality
        self.isSitting=isSitting 

    def sit_down(self):
        self.isSitting=True

    def stand_up(self):
        self.isSitting=False

    def change_pos(self):
        if (self.isSitting==True):
            self.isSitting==False
        else: 
            self.isSitting==True

p1=Person("Alice", "aggressive", False)
p2=Person("Becky", "talkative", True)

print (p1.name,'is', p1.isSitting ,'about sitting')
print (p2.name,'is', p2.isSitting ,'about sitting')

p2.change_pos()

print (p1.name,'is', p1.isSitting ,'about sitting')
print (p2.name,'is', p2.isSitting ,'about sitting')

The output is:

Alice is False about sitting
Becky is True about sitting
Alice is False about sitting
Becky is True about sitting

You have 2 typos in `change_pos`. You have `self.isSitting==False` instead of `self.isSitting=False` — PM 2Ring, Jul 14 '18 at 09:09
just `def change_pos(self): self.isSitting = not self.isSitting` — Jean-François Fabre, Jul 14 '18 at 09:11
As for your 2nd question, just do `for p in (p1, p2): p.change_pos()` — PM 2Ring, Jul 14 '18 at 09:13
BTW, don't do tests that compare something to True or False, like your `if (self.isSitting==True):`. Instead, write that test like this: `if self.isSitting:` — PM 2Ring, Jul 14 '18 at 09:22
Thank you... and what if I would have thousands of instances (and not just p1,p2) ? so, what can be written instead: for p in (p1, p2): p.change_pos() — Eli, Jul 14 '18 at 10:03

Python - operate a method

0 Answers0