set style value using Javascript variable not work

Question

Using javascript variable for setting CSS style values not work, this is my javascript code:

imageH.src = "image.jpg";
imageH.onload = function() {
    var valueH = (this.height/this.width)*100;
  }

var div1 = document.createElement('div');
div.style.paddingTop = valueH + '%';

this not work, but if i use the value betwen "" :

div.style.paddingTop = "60%";

it work.

Thanks!!

`valueH` is only defined inside the `onload` function. Declare it outside instead. — , Jul 17 '18 at 14:55
Also note that the function runs *after* your `div1` stuff (which completely escaped me previously) — , Jul 17 '18 at 16:21

score 0 · Answer 1 · answered Jul 17 '18 at 14:57

0

Move valueH outside of function:

imageH.src = "image.jpg";

var valueH;

imageH.onload = function() {
    valueH = (this.height/this.width)*100;
  }

var div1 = document.createElement('div');
div.style.paddingTop = valueH + '%';

answered Jul 17 '18 at 14:57

Axel

4,365
11
63
122

set style value using Javascript variable not work

1 Answers1