I can't break out of while True loop in Python 3.7

Question

import random


while True:
    dice_number = random.randint(1, 6)

    print('You rolled ' + str(dice_number))

    print("Do you wish to continue? [Y/n]" )
    if input() == 'Y' or 'y':
        pass
    else:
        break

I just wasted half an hour trying to figure this out, still don't know what I did wrong. Can anyone help me please

Endlessly duplicated, see e.g. https://stackoverflow.com/q/15112125/3001761 — jonrsharpe, Jul 20 '18 at 16:02

Eduardo Soares · Accepted Answer · 2018-07-23T00:30:04.523

1

You can't do or == 'y'. You have to put the whole logic expression again. Like this:

import random


while True:
    dice_number = random.randint(1, 6)

    print('You rolled ' + str(dice_number))

    print("Do you wish to continue? [Y/n]" )
    a = input()

    if a == 'Y' or a == 'y':
        pass
    else:
        break

edited Jul 23 '18 at 00:30

answered Jul 20 '18 at 16:03

Eduardo Soares

992
4
14

1

I'd recommend to use `a in ('Y', 'y')` for multiple choices. – sashaaero Jul 20 '18 at 16:27

I can't break out of while True loop in Python 3.7

1 Answers1