Move Files From One Directory to Another Using Shell Script

Question

I have written a shell script which moves all the files from a specific directory to another directory.

#!/bin/bash

# Command to execute
execute_cmd=mv

path=/home/ypsvc/sa_automation

# Files inside actual_dir has to be moved
actual_dir="$path/sa_cx_data"

# This is the directory where files will be moved and kept
backup_dir="$path/file_backup/"

# Move each file from actual_dir to backup_dir

echo "Moving files to backup_dir"

for f in $actual_dir/*.xlsx
# echo f
do
 $execute_cmd "$f" $backup_dir
done

echo "Moving of files completed"

But when I run this, it gives below error:

Moving files to backup_dir
: not found.sh: 14: file_backup.sh:
file_backup.sh: 16: file_backup.sh: Syntax error: word unexpected (expecting "do")

Can someone help in resolving this?

PS: file_backup is already created and proper permission has been given to the script.

Running the script with -x gives below result:

+
: not found.sh: 2: file_backup.sh:
+ execute_cmd=mv
+
: not found.sh: 5: file_backup.sh:
+ path=/home/ypsvc/sa_automation
+
: not found.sh: 7: file_backup.sh:
/sa_cx_datar=/home/ypsvc/sa_automation
+
: not found.sh: 10: file_backup.sh:
/file_backup//home/ypsvc/sa_automation
+
: not found.sh: 13: file_backup.sh:
+
: not found.sh: 15: file_backup.sh:
+ echo Moving files to backup_dir
Moving files to backup_dir
+
: not found.sh: 17: file_backup.sh:
file_backup.sh: 20: file_backup.sh: Syntax error: word unexpected (expecting "do")

FYI: paste your code in https://www.shellcheck.net/, it will point out some improvements. — Nic3500, Jul 23 '18 at 11:36
It is not a solution, therefore I did not put it as an answer. — Nic3500, Jul 23 '18 at 11:55
@Sumit: I don't think you have posted the exact script which causes the trouble, because the line numbers in the error messages don't correspond to the lines you have posted. Run the script with `-x` and let us know the output. — user1934428, Jul 23 '18 at 11:56
The command variable and the loop are basically useless, you can just `mv "$actual_dir"/*.xlsx "$backup_dir"` — tripleee, Jul 23 '18 at 15:07

score 0 · Answer 1 · answered Jul 23 '18 at 11:41

0

Try with this code

#!/bin/bash

# Command to execute
execute_cmd=mv

path="/home/ypsvc/sa_automation"

# Files inside actual_dir has to be moved
actual_dir="$path/sa_cx_data"

# This is the directory where files will be moved and kept
backup_dir="$path/file_backup/"

# Move each file from actual_dir to backup_dir

echo "Moving files to backup_dir"

for f in $(find $actual_dir -type f -name *.xlsx); ## used find here, with semicolon
do
 echo $f
 $execute_cmd $f $backup_dir
done

echo "Moving of files completed"

answered Jul 23 '18 at 11:41

ggupta

675
1
10
27

I tried, but it gives same error! – Sumit Jul 23 '18 at 13:03
@Sumit this worked for me, as i have tested this. Please check with other things. Like version and all. Thanks. – ggupta Jul 25 '18 at 10:24

Brudex · Answer 2 · 2018-07-24T12:16:28.377

0

You can try this one , should work

#!/bin/bash
path="/home/ypsvc/sa_automation"
# Files inside actual_dir has to be moved
actual_dir="$path/sa_cx_data"
find $path -name '*.xlsx' -exec mv {} $actual_dir \;

edited Jul 24 '18 at 12:16

answered Jul 23 '18 at 12:51

Brudex

35
7

You probably mean : find $path -name '*.xlsx' -exec mv {} $actual_dir \; – Andre Gelinas Jul 23 '18 at 13:52

Move Files From One Directory to Another Using Shell Script

2 Answers2