Embed Javascript in php file, syntax

Question

Using ajax I post data to php file where I have loop with code below.

Part of my code where I can't properly format onclick event:

$result .= '<a href="#" onclick="$("#element").dialog("open");" ></a>';

I tried to escape double quotes with backslash, but no luck. Using backslashes, in console I see: Somehow from nowhere "=" appears, also all backslashes are printed. Code doesn't work.

Could someone help to figure out where I made a mistake in syntax? Thank you.

Edited, to better explain why I didn't find answer in other posts. — Grufas, Jul 30 '18 at 13:28

score 1 · Answer 1 · answered Jul 30 '18 at 13:42

When parsing the HTML, the browser will read the onclick="$("#element" part, and infer that attribute onclick equals "$(", because it thought it found the closing double quotes. So, you'll need to escape the double quote character after the $(. Since you're using $result .= 'some_string' (I want to empasize on the single quote being used here), you are unable to escape the double quote character within the single quoted string. Thus, you'll need something like this: $result .= '<a href="#" onclick="$(\'#element\').dialog(\'open\');" ></a>';

Now, php will translate \' to just ' while rendering, so the final output of the string will be

<a href="#" onclick="$('#element').dialog('open');" ></a>

I hope this helps.

score 1 · Accepted Answer · edited Jul 30 '18 at 14:08

In your string there are double quotes, followed by content wrapped again in double quotes. The second quotes should be single quotes, but that would terminate the string. So you will have to escape them.

The desired html code should look like this:

<a href="#" onclick="$('#element').dialog('open');"></a>

to achieve this, you will have to change your PHP code to the e.g. the following:

$result .= '<a href="#" onclick="$(\'#element\').dialog(\'open\');"></a>';

prashant · Answer 3 · 2018-07-30T13:08:18.217

-2

Double quotes should be escaped

$result .= '<a href="#" onclick="$(\"#element\").dialog(\"open\");" ></a>';

Another way is

$result .= `<a href="#" onclick="$('#element').dialog('open');" ></a>`;

edited Jul 30 '18 at 13:08

answered Jul 30 '18 at 13:05

prashant

127
2
10

3

Shouldn't `dialog("open")` be escaped then too? – brombeer Jul 30 '18 at 13:06
3

Plus, I think those backticks in your second code won't work. – brombeer Jul 30 '18 at 13:07
Previously I tried to escape double quotes, but no luch. Also this time in console I see: Somehow from nowhere I see "=", from where it comes? Also code doesn't work. – Grufas Jul 30 '18 at 13:22
It worked after I changed double quotes to single... – Grufas Jul 30 '18 at 13:32
Of course it needs to be escaped otherwise the PHP string will be terminated as it starts with a singe quote. – Musa Jul 30 '18 at 13:38
Backtick in PHP is to execute a shell command not to define a string literal – Musa Jul 30 '18 at 13:53

Embed Javascript in php file, syntax

3 Answers3