Javascript popup link in php

Question

i have this php code:

echo "<div class='show-popup'><a class='button-popup-container-right' href='javascript:apri('popup.html');' target='_blank'><i class='far fa-play-circle'></i>&nbsp;ASCOLTA LA RADIO</span></a></div>"

but, when i click on the link the path is only "javascript:apri("

I have inserted this script in the footer of the page

function apri(url) { 
    newin = window.open(url,'Player','top=50, left=50,scrollbars=no,resizable=yes,width=400,height=550,status=no,location=no,toolbar=no,nomenubar=no');
}

Can anyone help me please?

Escape the inner quotes `href='javascript:apri(\'popup.html\');'` — mplungjan, Aug 21 '18 at 15:01
Also `javascript:` is NOT recommended. Use onclick, or better, data-attributes — mplungjan, Aug 21 '18 at 15:03
@mplungjan — ```\``` is not an escape character in HTML … and will be consumed by the PHP engine anyway, so that will make no difference. — Quentin, Aug 21 '18 at 15:03
@mplungjan — Doesn't matter. The problem is at the HTML level. The ```\``` would never reach the JS parser. — Quentin, Aug 21 '18 at 15:05
Anyway. Suggestion: `echo "
ASCOLTA LA RADIO
";` using `function apri(link) { var w = window.open(this.href); return w?false:true}` — mplungjan, Aug 21 '18 at 15:06

Quentin · Answer 1 · 2018-08-21T15:02:42.513

-2

href='javascript:apri('

The first ' marks the start of the attribute value. The second ' marks the end of the attribute value.

If you want to include ' as data then you need to either use " to delimit the attribute value or to escape the ' as '.

You can avoid this problem by writing Unobtrusive JavaScript and binding your event handlers with addEventListener.

edited Aug 21 '18 at 15:02

answered Aug 21 '18 at 15:01

Quentin

914,110
126
1,211
1,335

Javascript popup link in php

1 Answers1