JSON Parsing error: No value for JSON array

Question

I have a code where i should pass an static user id for authentication and then fetch the JSON response from the URL and display it in listview. But i get an error that says "JSON Parsing error: No value in (JSON array)". Please help

MainActivity.java:

 public class MainActivity extends AppCompatActivity {

        private String TAG = MainActivity.class.getSimpleName();

        private ProgressDialog pDialog;
        private ListView lv;

        // URL to get contacts JSON
        private static String url = "url";

        ArrayList<HashMap<String, String>> contactList;

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_main);

            contactList = new ArrayList<>();

            lv = (ListView) findViewById(R.id.list);

            new GetContacts().execute();
        }

        /**
         * Async task class to get json by making HTTP call
         */
        private class GetContacts extends AsyncTask<Void, Void, Void> {

            @Override
            protected void onPreExecute() {
                super.onPreExecute();
                // Showing progress dialog
                pDialog = new ProgressDialog(MainActivity.this);
                pDialog.setMessage("Please wait...");
                pDialog.setCancelable(false);
                pDialog.show();

            }

            @Override
            protected Void doInBackground(Void... arg0) {


     List<NameValuePair> list=new ArrayList<>();
                list.add(new BasicNameValuePair("user_id", "2"));

                HttpHandler sh = new HttpHandler();



                // Making a request to url and getting response
                String jsonStr = sh.makeServiceCall(url);

                Log.e(TAG, "Response from url: " + jsonStr);

                if (jsonStr != null) {
                    try {
                        JSONObject jsonObj = new JSONObject(jsonStr);

                        // Getting JSON Array node
                        JSONArray contacts = jsonObj.getJSONArray("promotion_lists");

                        // looping through All Contacts
                        for (int i = 0; i < contacts.length(); i++) {
                            JSONObject c = contacts.getJSONObject(i);

                            String promotion_id = c.getString("promotion_id");
                            String promotion_title = c.getString("promotion_title");
                            String promotion_description = c.getString("promotion_description");
    //
                            HashMap<String, String> contact = new HashMap<>();

                            // adding each child node to HashMap key => value
                            contact.put("promotion_id", promotion_id);
                            contact.put("promotion_title", promotion_title);
                            contact.put("promotion_description", promotion_description);

                            // adding contact to contact list
                            contactList.add(contact);
                        }
                    } catch (final JSONException e) {
                        Log.e(TAG, "Json parsing error: " + e.getMessage());
                        runOnUiThread(new Runnable() {
                            @Override
                            public void run() {
                                Toast.makeText(getApplicationContext(),
                                        "Json parsing error: " + e.getMessage(),
                                        Toast.LENGTH_LONG)
                                        .show();
                            }
                        });

                    }
                } else {
                    Log.e(TAG, "Couldn't get json from server.");
                    runOnUiThread(new Runnable() {
                        @Override
                        public void run() {
                            Toast.makeText(getApplicationContext(),
                                    "Couldn't get json from server. Check LogCat for possible errors!",
                                    Toast.LENGTH_LONG)
                                    .show();
                        }
                    });

                }

                return null;
            }

            @Override
            protected void onPostExecute(Void result) {
                super.onPostExecute(result);
                Log.e("SignUpRsp", String.valueOf(result));

                // Dismiss the progress dialog
                if (pDialog.isShowing())
                    pDialog.dismiss();
                /**
                 * Updating parsed JSON data into ListView
                 * */
                ListAdapter adapter = new SimpleAdapter(
                        MainActivity.this, contactList,
                        R.layout.list_item, new String[]{"promotion_id", "promotion_title",
                        "promotion_description"}, new int[]{R.id.promotion_id,
                        R.id.promotion_title, R.id.promotion_desc});

                lv.setAdapter(adapter);
            }


        }
        public String PostData(String[] valuse) {
            String s="";


            try
            {
                HttpClient httpClient=new DefaultHttpClient();
                HttpPost httpPost=new HttpPost("url");

                List<NameValuePair> list=new ArrayList<>();
                list.add(new BasicNameValuePair("user_id", "value"));


                httpPost.setEntity(new UrlEncodedFormEntity(list));
                HttpResponse httpResponse=  httpClient.execute(httpPost);

                HttpEntity httpEntity=httpResponse.getEntity();
                s= readResponse(httpResponse);

            }
            catch(Exception exception)  {}
            return s;


        }
        public String readResponse(HttpResponse res) {
            InputStream is=null;
            String return_text="";
            try {
                is=res.getEntity().getContent();
                BufferedReader bufferedReader=new BufferedReader(new InputStreamReader(is));
                String line="";
                StringBuffer sb=new StringBuffer();
                while ((line=bufferedReader.readLine())!=null)
                {
                    sb.append(line);
                }
                return_text=sb.toString();
            } catch (Exception e)
            {

            }
            return return_text;

        }
    }

JSON Response:

  {
            "status": "1",
            "message": "Ok",
            "promotion_lists": [
                {
                    "promotion_id": "3",
                    "promotion_image_name": "1.jpg",
                    "promotion_image_url": "url.jpg",
                    "promotion_title": "winner",
                    "promotion_description": "good\ngold\nred",
                    "admin_status": "1",
                    "promotion_status": "1",
                    "promotion_status_description": "Live"
                },

            ]
        }

May be your response is `null` What is the output of thos log `Log.e(TAG, "Response from url: " + jsonStr);` — AskNilesh, Aug 23 '18 at 04:57
@NileshRathod: Response from url: {"status":"0","message":"User not found"} — Elackya, Aug 23 '18 at 04:59
there is an issue with JSON received, here last comma(,) is not required in the array. Maybe you need to check with Server/Url from where you are receiving it. — Swapnil, Aug 23 '18 at 05:05

score 1 · Answer 1 · answered Aug 23 '18 at 05:03

Your json also has an issue, can you try with this output json. Last comma(,) in an array is not required.

{
        "status": "1",
        "message": "Ok",
        "promotion_lists": [
            {
                "promotion_id": "3",
                "promotion_image_name": "1.jpg",
                "promotion_image_url": "url.jpg",
                "promotion_title": "winner",
                "promotion_description": "good\ngold\nred",
                "admin_status": "1",
                "promotion_status": "1",
                "promotion_status_description": "Live"
            }
        ]
}

score 1 · Accepted Answer · edited Aug 23 '18 at 06:56

1

Your JSON parsing is correct

You need to parse your JSON if your response status response code is 1

SAMPLE CODE

Try this

    if (jsonStr != null) {
        try {
            JSONObject jsonObj = new JSONObject(jsonStr);



            // check here of your status of response 
            // is status is 0 USER NOT FOUND
            if(jsonObj.getString("status").equals("0")){

           MainActivity.this.runOnUiThread(new Runnable() {
               @Override
              public void run() {
            Toast.makeText(MainActivity.this, jsonObj.getString("message"), Toast.LENGTH_SHORT).show();
               }
           });



            // is status is 1 PARSE YOUR JSON
            }else {
                JSONArray contacts = jsonObj.getJSONArray("promotion_lists");

                // looping through All Contacts
                for (int i = 0; i < contacts.length(); i++) {
                    JSONObject c = contacts.getJSONObject(i);

                    String promotion_id = c.getString("promotion_id");
                    String promotion_title = c.getString("promotion_title");
                    String promotion_description = c.getString("promotion_description");

                    HashMap<String, String> contact = new HashMap<>();

                    // adding each child node to HashMap key => value
                    contact.put("promotion_id", promotion_id);
                    contact.put("promotion_title", promotion_title);
                    contact.put("promotion_description", promotion_description);

                    // adding contact to contact list
                    contactList.add(contact);
                }
            }

        } catch (final JSONException e) {
            Log.e(TAG, "Json parsing error: " + e.getMessage());
            runOnUiThread(new Runnable() {
                @Override
                public void run() {
                    Toast.makeText(getApplicationContext(),
                            "Json parsing error: " + e.getMessage(),
                            Toast.LENGTH_LONG)
                            .show();
                }
            });

        }
}

edited Aug 23 '18 at 06:56

Quick learner

10,632
4
45
55

answered Aug 23 '18 at 05:07

AskNilesh

67,701
16
123
163

Ok i will try now – Elackya Aug 23 '18 at 05:14
I am getting an runtime exception – Elackya Aug 23 '18 at 05:19
@Elackya share that exception – AskNilesh Aug 23 '18 at 05:19
@Elackya try updated answer – AskNilesh Aug 23 '18 at 05:20
@Elackya did u solved it? – AskNilesh Aug 23 '18 at 05:56
I'm receiving the following error : java.lang.RuntimeException: An error occurred while executing doInBackground() – Elackya Aug 23 '18 at 05:58
@Elackya share whole error with question – AskNilesh Aug 23 '18 at 05:58
ok give me few mins – Elackya Aug 23 '18 at 06:02
08-23 11:30:25.018 12504-12504/? E/MultiWindowProxy: getServiceInstance failed! 08-23 11:30:25.568 12504-12520/? E/MainActivity: Response from url: {"status":"0","message":"User not found"} 08-23 11:30:25.571 12504-12520/? E/AndroidRuntime: FATAL EXCEPTION: AsyncTask #1 – Elackya Aug 23 '18 at 06:06
@Elackya share your crash log as text not as image – AskNilesh Aug 23 '18 at 06:07
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/178580/discussion-between-elackya-and-nilesh-rathod). – Elackya Aug 23 '18 at 06:09

Quick learner · Answer 3 · 2018-08-23T07:11:03.883

You can use this solution

public class GetContacts extends AsyncTask<String, Void, String> {
        protected void onPreExecute() {
            pDialog = new ProgressDialog(MainActivity.this);
            pDialog.setMessage("Please wait...");
            pDialog.setCancelable(false);
            pDialog.show();
        }

        protected String doInBackground(String... arg0) {

            try {
                URL url = new URL(URL HERE);
                HttpURLConnection conn = (HttpURLConnection) url.openConnection();
                conn.setRequestMethod("POST");
                conn.setRequestProperty("Content-Type", "application/json;charset=UTF-8");
                conn.setRequestProperty("Accept", "application/json");
                conn.setDoOutput(true);
                conn.setDoInput(true);
                conn.setReadTimeout(5000);
                conn.setConnectTimeout(5000);
                JSONObject postDataParams = new JSONObject();
                postDataParams.put("user_id", user_id);
                Log.i("JSON", postDataParams.toString());
                DataOutputStream os = new DataOutputStream(conn.getOutputStream());
                //os.writeBytes(URLEncoder.encode(jsonParam.toString(), "UTF-8"));
                os.writeBytes(postDataParams.toString());
                os.flush();
                os.close();

                Log.i("STATUS", String.valueOf(conn.getResponseCode()));
                Log.i("MSG", conn.getResponseMessage());


                int responseCode = conn.getResponseCode();

                if (responseCode == HttpsURLConnection.HTTP_OK) {

                    BufferedReader in = new BufferedReader(new
                            InputStreamReader(
                            conn.getInputStream()));

                    StringBuffer sb = new StringBuffer("");
                    String line = "";

                    while ((line = in.readLine()) != null) {

                        sb.append(line);
                        break;
                    }

                    in.close();
                    conn.disconnect();
                    return sb.toString();

                } else {
                    conn.disconnect();
                    return new String("false : " + responseCode);
                }

            } catch (Exception e) {
                return new String("Exception: " + e.getMessage());
            }

        }

        @Override
        protected void onPostExecute(String jsonStr) {
            try {
                 pDialog();
                Log.e(TAG, "Response from url: " + jsonStr);

            if (jsonStr != null) {
                try {
                    JSONObject jsonObj = new JSONObject(jsonStr);

                    // Getting JSON Array node
                    JSONArray contacts = jsonObj.getJSONArray("promotion_lists");

                    // looping through All Contacts
                    for (int i = 0; i < contacts.length(); i++) {
                        JSONObject c = contacts.getJSONObject(i);

                        String promotion_id = c.getString("promotion_id");
                        String promotion_title = c.getString("promotion_title");
                        String promotion_description = c.getString("promotion_description");
//
                        HashMap<String, String> contact = new HashMap<>();

                        // adding each child node to HashMap key => value
                        contact.put("promotion_id", promotion_id);
                        contact.put("promotion_title", promotion_title);
                        contact.put("promotion_description", promotion_description);

                        // adding contact to contact list
                        contactList.add(contact);
                    }
/**
             * Updating parsed JSON data into ListView
             * */
            ListAdapter adapter = new SimpleAdapter(
                    MainActivity.this, contactList,
                    R.layout.list_item, new String[]{"promotion_id", "promotion_title",
                    "promotion_description"}, new int[]{R.id.promotion_id,
                    R.id.promotion_title, R.id.promotion_desc});

            lv.setAdapter(adapter);

                } catch (final JSONException e) {
                    Log.e(TAG, "Json parsing error: " + e.getMessage());
                    Toast.makeText(getApplicationContext(),
                                    "Json parsing error: " + e.getMessage(),
                                    Toast.LENGTH_LONG)
                                    .show();

                }
            } else {
                Log.e(TAG, "Couldn't get json from server.");
                Toast.makeText(getApplicationContext(),
                                    "Json parsing error: " + e.getMessage(),
                                    Toast.LENGTH_LONG)
                                    .show();

            }
            } catch (JSONException e) {
                e.printStackTrace();
            }


        }
    }

One more thing you dont need to use runOnUiThread in Asynctask because both are helper threads , which are used to Update UI,you dont have to use runOnUIThread in it , just simple show toast without using it, it will show it , read the documentation https://developer.android.com/guide/components/processes-and-threads

When i run this code the screen keeps on loading for a long time . — Elackya, Aug 23 '18 at 06:51
can you please just check if your web service using any content type likeapplication/json ? — Quick learner, Aug 23 '18 at 06:55
you can remove these lines if the content type is not json in headers dear , conn.setRequestProperty("Content-Type", "application/json;charset=UTF-8"); conn.setRequestProperty("Accept", "application/json"); — Quick learner, Aug 23 '18 at 06:57
Let us [continue this discussion in chat](https://chat.stackoverflow.com/rooms/178586/discussion-between-elackya-and-quick-learner). — Elackya, Aug 23 '18 at 07:10

score 1 · Answer 4 · answered Aug 23 '18 at 05:09

JSONArray throw error because promotion_lists with a item but has needless comma.

{
    "status": "1",
    "message": "Ok",
    "promotion_lists": [
        {
            "promotion_id": "3",
            "promotion_image_name": "1.jpg",
            "promotion_image_url": "url.jpg",
            "promotion_title": "winner",
            "promotion_description": "good\ngold\nred",
            "admin_status": "1",
            "promotion_status": "1",
            "promotion_status_description": "Live"
        }
    ]
}

score 1 · Answer 5 · answered Aug 23 '18 at 05:11

1

Your JSON parse looks fine. The issue is with the your JSON response. It is not a valid JSON Response as there is a unnecessary comma after the JSON Array "promotion_lists". Try removing the comma.

answered Aug 23 '18 at 05:11

Pradeep Kumar

102
1
7

JSON Parsing error: No value for JSON array

5 Answers5