App crashes on activity which shows user's posts

Question

I am making a social network app and in the activity that will show the user's posts, the application crashes.

postsActivity.java

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    mAuth = FirebaseAuth.getInstance();
    currentUserId = mAuth.getCurrentUser().getUid();

    userRef = FirebaseDatabase.getInstance().getReference().child("Users").child(currentUserId);


    mtoolbar = (Toolbar) findViewById(R.id.mainpagetoolbar);
    setSupportActionBar(mtoolbar);
    getSupportActionBar().setTitle("Home");

    drawerLayout = (DrawerLayout) findViewById(R.id.drawer);
    drawerToggle = new ActionBarDrawerToggle(MainActivity.this, drawerLayout, R.string.drwaer_open, R.string.drawer_close);
    drawerLayout.addDrawerListener(drawerToggle);
    drawerToggle.syncState();
    getSupportActionBar().setDisplayHomeAsUpEnabled(true);
    navigationView = (NavigationView) findViewById(R.id.navigation);
    View view = navigationView.inflateHeaderView(R.layout.navigation_header);
    navProfileImage = (CircleImageView) view.findViewById(R.id.user_photo);
    navProfileUserName = (TextView) view.findViewById(R.id.username);


    postList = (RecyclerView) findViewById(R.id.users_posts);

    userRef.child(currentUserId).addValueEventListener(new ValueEventListener() {
        @Override
        public void onDataChange(@NonNull DataSnapshot dataSnapshot) {

            if (dataSnapshot.exists()) {


                if (dataSnapshot.hasChild("fullname")) {
                    String fullname = dataSnapshot.child("fullname").getValue().toString();
                    navProfileUserName.setText(fullname);
                }

                if (dataSnapshot.hasChild("profileimage")) {
                    String image = dataSnapshot.child("profileimage").getValue().toString();


                    Picasso.with(MainActivity.this).load(image).placeholder(R.drawable.profile).into(navProfileImage);
                }


            }

        }

        @Override
        public void onCancelled(@NonNull DatabaseError databaseError) {

        }
    });

    navigationView.setNavigationItemSelectedListener(new NavigationView.OnNavigationItemSelectedListener() {
        @Override
        public boolean onNavigationItemSelected(@NonNull MenuItem item) {
            UserMenuSelector(item);
            return false;
        }
    });

}

@Override
protected void onStart() {
    super.onStart();

    FirebaseUser currrentUser = mAuth.getCurrentUser();
    if (currrentUser == null) {
        sendUsertoLoginActivity();
    } else {
        CheckUserExistance();
    }
}

private void CheckUserExistance() {
    final String user_id = mAuth.getCurrentUser().getUid();

    userRef.addValueEventListener(new ValueEventListener() {
        @Override
        public void onDataChange(@NonNull DataSnapshot dataSnapshot) {
            if (!dataSnapshot.hasChild(user_id)) {
                sendUserToSetUpActivity();
            }
        }

        @Override
        public void onCancelled(@NonNull DatabaseError databaseError) {

        }
    });

}

private void sendUserToSetUpActivity() {
    Intent setupIntent = new Intent(MainActivity.this, SetupActivity.class);
    setupIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    startActivity(setupIntent);
    finish();
}

private void sendUsertoLoginActivity() {
    Intent loginIntent = new Intent(MainActivity.this, SignInActivity.class);
    loginIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    startActivity(loginIntent);
    finish();
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    if (drawerToggle.onOptionsItemSelected(item)) {
        return true;
    }
    return super.onOptionsItemSelected(item);
}

private void UserMenuSelector(MenuItem item) {

    switch (item.getItemId()) {
        case R.id.nav_Profile:
            Toast.makeText(this, "profile ", Toast.LENGTH_SHORT).show();
            break;
        case R.id.nav_home:
            Toast.makeText(this, "Home ", Toast.LENGTH_SHORT).show();
            break;


        case R.id.nav_find_friends:
            Toast.makeText(this, "Find Friends", Toast.LENGTH_SHORT).show();
            break;

        case R.id.nav_messeages:
            Toast.makeText(this, "Messages", Toast.LENGTH_SHORT).show();
            break;

        case R.id.nav_settings:
            Toast.makeText(this, "Settings ", Toast.LENGTH_SHORT).show();
            break;

        case R.id.nav_friends:
            Toast.makeText(this, "friends ", Toast.LENGTH_SHORT).show();
            break;
        case R.id.nav_SignOut:
            mAuth.signOut();
            sendUsertoLoginActivity();
            break;
    }
}

LOGCAT message displayed java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String com.google.firebase.auth.FirebaseUser.getUid()' on a null object reference

Tried to search for a solution but couldn't find one that met my criteria.

mAuth.getCurrentUser() returns you a null ... read the method's doc — Alessio, Aug 24 '18 at 06:13
see hee : https://stackoverflow.com/questions/44979970/java-lang-nullpointerexception-attempt-to-invoke-virtual-method-java-lang-stri — Donatic, Aug 24 '18 at 06:15

score 1 · Answer 1 · answered Aug 24 '18 at 06:20

1

The crash is because of no user is linked, i.e., getCurrentUser() is null.

if (FirebaseAuth.getInstance().getCurrentUser() != null) {
    mUserID = FirebaseAuth.getInstance().getCurrentUser().getUid();
} else {

//check for this

}

answered Aug 24 '18 at 06:20

bugfreerammohan

1,471
1
7
22

score 0 · Answer 2 · answered Aug 24 '18 at 06:16

0

Because the user is not logged in yet, mAuth.getCurrentUser() returns null and your invoking getUid() on it, which throws an NullPointerException.

answered Aug 24 '18 at 06:16

Donatic

323
1
13

Krishna Sharma · Accepted Answer · 2018-08-24T06:38:56.970

You need to add null check wherever you are calling mAuth.getCurrentUser();

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_main);

    mAuth = FirebaseAuth.getInstance();


    mtoolbar = (Toolbar) findViewById(R.id.mainpagetoolbar);
    setSupportActionBar(mtoolbar);
    getSupportActionBar().setTitle("Home");

    drawerLayout = (DrawerLayout) findViewById(R.id.drawer);
    drawerToggle = new ActionBarDrawerToggle(MainActivity.this, drawerLayout, R.string.drwaer_open, R.string.drawer_close);
    drawerLayout.addDrawerListener(drawerToggle);
    drawerToggle.syncState();
    getSupportActionBar().setDisplayHomeAsUpEnabled(true);
    navigationView = (NavigationView) findViewById(R.id.navigation);
    View view = navigationView.inflateHeaderView(R.layout.navigation_header);
    navProfileImage = (CircleImageView) view.findViewById(R.id.user_photo);
    navProfileUserName = (TextView) view.findViewById(R.id.username);


    postList = (RecyclerView) findViewById(R.id.users_posts);

    if(mAuth.getCurrentUser()!=null){

        currentUserId = mAuth.getCurrentUser().getUid();

        userRef = FirebaseDatabase.getInstance().getReference().child("Users").child(currentUserId);
        userRef.child(currentUserId).addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(@NonNull DataSnapshot dataSnapshot) {

                if (dataSnapshot.exists()) {


                    if (dataSnapshot.hasChild("fullname")) {
                        String fullname = dataSnapshot.child("fullname").getValue().toString();
                        navProfileUserName.setText(fullname);
                    }

                    if (dataSnapshot.hasChild("profileimage")) {
                        String image = dataSnapshot.child("profileimage").getValue().toString();


                        Picasso.with(MainActivity.this).load(image).placeholder(R.drawable.profile).into(navProfileImage);
                    }


                }

            }

            @Override
            public void onCancelled(@NonNull DatabaseError databaseError) {

            }
        });
    }

    navigationView.setNavigationItemSelectedListener(new NavigationView.OnNavigationItemSelectedListener() {
        @Override
        public boolean onNavigationItemSelected(@NonNull MenuItem item) {
            UserMenuSelector(item);
            return false;
        }
    });

}

@Override
protected void onStart() {
    super.onStart();

    FirebaseUser currrentUser = mAuth.getCurrentUser();
    if (currrentUser == null) {
        sendUsertoLoginActivity();
    } else {
        CheckUserExistance();
    }
}

private void CheckUserExistance() {
    FirebaseUser user = mAuth.getCurrentUser();
    if (user != null) {
        // User is signed in
        final String user_id = user.getUid();
        userRef.addValueEventListener(new ValueEventListener() {
            @Override
            public void onDataChange(@NonNull DataSnapshot dataSnapshot) {
                if (!dataSnapshot.hasChild(user_id)) {
                    sendUserToSetUpActivity();
                }
            }
            @Override
            public void onCancelled(@NonNull DatabaseError databaseError) {

            }
        });

    } else {
        // User is not signed in
        // Do some stuff
    }
}

private void sendUserToSetUpActivity() {
    Intent setupIntent = new Intent(MainActivity.this, SetupActivity.class);
    setupIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    startActivity(setupIntent);
    finish();
}

private void sendUsertoLoginActivity() {
    Intent loginIntent = new Intent(MainActivity.this, SignInActivity.class);
    loginIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
    startActivity(loginIntent);
    finish();
}

@Override
public boolean onOptionsItemSelected(MenuItem item) {
    if (drawerToggle.onOptionsItemSelected(item)) {
        return true;
    }
    return super.onOptionsItemSelected(item);
}

private void UserMenuSelector(MenuItem item) {

    switch (item.getItemId()) {
        case R.id.nav_Profile:
            Toast.makeText(this, "profile ", Toast.LENGTH_SHORT).show();
            break;
        case R.id.nav_home:
            Toast.makeText(this, "Home ", Toast.LENGTH_SHORT).show();
            break;


        case R.id.nav_find_friends:
            Toast.makeText(this, "Find Friends", Toast.LENGTH_SHORT).show();
            break;

        case R.id.nav_messeages:
            Toast.makeText(this, "Messages", Toast.LENGTH_SHORT).show();
            break;

        case R.id.nav_settings:
            Toast.makeText(this, "Settings ", Toast.LENGTH_SHORT).show();
            break;

        case R.id.nav_friends:
            Toast.makeText(this, "friends ", Toast.LENGTH_SHORT).show();
            break;
        case R.id.nav_SignOut:
            mAuth.signOut();
            sendUsertoLoginActivity();
            break;
    }
}

still not working ...i dont why – Amira Mohamed Aug 24 '18 at 06:31 — Amira Mohamed, Aug 24 '18 at 06:31
@AmiraMohamed still you getting NullPointerException ? – Krishna Sharma Aug 24 '18 at 06:33 — Krishna Sharma, Aug 24 '18 at 06:33
yes it still showing a nullPointerException – Amira Mohamed Aug 24 '18 at 06:35 — Amira Mohamed, Aug 24 '18 at 06:35
See the edited answer now – Krishna Sharma Aug 24 '18 at 06:39 — Krishna Sharma, Aug 24 '18 at 06:39
thx ....it worked fine – Amira Mohamed Aug 24 '18 at 06:44 — Amira Mohamed, Aug 24 '18 at 06:44

App crashes on activity which shows user's posts

3 Answers3