Shorten if else statement for active page link

Question

I am trying to make a active page link with my following codes. But as I add more pages in the future, this if else will be much more. Is there a way to make it shorter if else ?

<?php  
$urlarray=explode('/', $_SERVER["REQUEST_URI"]);
$pageActive = end($urlarray); 
$dashClass ='';  
$userClass = '';
$settingClass = '';
$activePage = array(
    "dashboard",
    "settings",
    "users"
);

if(in_array($pageActive, $activePage)) { 
    if($pageActive == 'users'){
        $userClass = 'class="active"';
    }else if($pageActive == 'dashboard'){
        $dashClass = 'class="active"';
    }else if($pageActive == 'settings'){
        $settingClass = 'class="active"';
    }
    ...
    ...
    ...
} 
?>

The echo html here

<ul>
  <li <?php echo $dashClass;?>></li>
  <li <?php echo $userClass;?>></li>
  <li <?php echo $settingClass;?>></li> 
</ul>

You cannot make it shorter if you have so many conditions to test. Why do you want to make it shorter? — Jay Blanchard, Sep 05 '18 at 12:03
what is the point of making the code shorter ? if you want to make it more readable, you can use a `switch` statement as stated by ggdx — ᴄʀᴏᴢᴇᴛ, Sep 05 '18 at 12:05
I used this in the past: https://codereview.stackexchange.com/q/159854/69564 — JustCarty, Sep 05 '18 at 12:05
BTW I found well over a dozen duplicates asking the same thing. — Jay Blanchard, Sep 05 '18 at 12:07

ggdx · Answer 1 · 2018-09-05T12:05:18.650

2

Use a switch

switch($pageActive) {
    // Users
    case 'users':
        $userClass = 'class="active"'
        break;

    // Dash
    case 'dashboard':
        $dashClass = 'class="active"'
        break;

    //something else
    case 'something-else':
        $somethingElseClass = 'class="blah"'
        break;

    // Default fallback one
    default:
        $userClass = 'class="active"';
        break;
}

EDIT You could just do

<li <?php if($pageActive === 'user'){ echo 'class="active"'; } ?>User</li>
<li <?php if($pageActive === 'dashboard'){ echo 'class="active"'; } ?>>Dashboard</li>

edited Sep 05 '18 at 12:05

answered Sep 05 '18 at 11:57

ggdx

3,024
4
32
48

Then if i have add more then page i need to add more case with your answer. But i am searching short code. – AlwaysStudent Sep 05 '18 at 11:59
Define "short" code? – ggdx Sep 05 '18 at 12:00
without so many `if()else if()else if()else.....` – AlwaysStudent Sep 05 '18 at 12:01
2

Where's the if/else in mine? – ggdx Sep 05 '18 at 12:02
1

He's talking about cases too @ggdx, he is looking for a shortcut that doesn't exist. – Jay Blanchard Sep 05 '18 at 12:03
@ggdx you don't have if/else but if I add more pages this means that i should be add more `case 'something-else';` – AlwaysStudent Sep 05 '18 at 12:04
@JayBlanchard Thank you – AlwaysStudent Sep 05 '18 at 12:05
Updated my answer – ggdx Sep 05 '18 at 12:05

score 0 · Answer 2 · answered Sep 05 '18 at 12:04

0

Their is already an array with list of menu items, having name as "activePage". You can try below code.

<?php
$urlarray=explode('/', $_SERVER["REQUEST_URI"]);
$pageActive = end($urlarray); 
$activePage = array('dashboard', 'settings', 'users');
?>

<ul>
    <?php
        foreach($activePage as $_key => $_value) {
            $menuSelect = '';
            if( in_array($pageActive, $activePage) ) {
                $menuSelect = 'class="active"';
            }
            ?><li <?php echo $menuSelect; ?>><?php echo $_value; ?></li><?php
        }
    ?>
</ul>

answered Sep 05 '18 at 12:04

Prasad Wargad

737
2
7
11

Do or do not, there is no "try". A ***good answer*** will always have an explanation of what was done and why it was done in such a manner, not only for the OP but for future visitors to SO. – Jay Blanchard Sep 05 '18 at 12:06
TRUE, I guess my answer too solving the issue, without need to put much if else. – Prasad Wargad Sep 05 '18 at 12:09

Shorten if else statement for active page link

2 Answers2