Index was outside the bounds of the array. How to solve this problem?

Question

using System;
using System.IO;

namespace _2._1
{
class Program
{
    public struct nariai
    {
        public string vardas;
        public string pavarde;
        public double pinigai;
    };
    static void Main(string[] args)
    {
        StreamReader failas = new StreamReader("nariai.txt");
        string a = failas.ReadLine();
        int nariuKiekis = int.Parse(a);
        nariai[] narys = new nariai[nariuKiekis];
        string[] info = new string[nariuKiekis];
        for (int i = 0; i < nariuKiekis; i++)
        {
            info[i] = failas.ReadLine();
            string[] informacija = info[i].Split(' ');
            narys[i].vardas = informacija[i];
            narys[i].pavarde = informacija[i + 1];
            narys[i].pinigai = double.Parse(informacija[i + 2]);
            Console.WriteLine("{0} {1} {2}", narys[0].vardas, narys[0].pavarde, narys[0].pinigai);
        }
    }
}
}

My file looks like that. file

And i am getting this error in the console. console

Why it isn't showing the "Almeda Norkute 25.70" ?

Could you add the content of file and error description to the question, so that it remains when question is solved and links you added will became broken? — Belurd, Sep 13 '18 at 14:04
If you come across this message, step through your code over the line , where it says the error occurs and check the values of your indices. Then think about why they have the values they have. — Fildor, Sep 13 '18 at 14:09

Mighty Badaboom · Accepted Answer · 2018-09-13T14:10:50.200

8

Instead of

narys[i].vardas = informacija[i];
narys[i].pavarde = informacija[i + 1];
narys[i].pinigai = double.Parse(informacija[i + 2]);

write

narys[i].vardas = informacija[0];
narys[i].pavarde = informacija[1];
narys[i].pinigai = double.Parse(informacija[2]);

Your informacija contains one line and one line always has 3 items in your example. If you need i to access these you get the error because you're trying to access position which are not existing.

And use

Console.WriteLine("{0} {1} {2}", narys[i].vardas, narys[i].pavarde, narys[i].pinigai);

Otherwise you would write always the first record in the console ;)

edited Sep 13 '18 at 14:10

answered Sep 13 '18 at 14:06

Mighty Badaboom

6,067
5
34
51

Then i'm getting this http://www.part.lt/img/ae3e8916ecbc05fbbe9a68bcd3099ca895.PNG – Lukas Velička Sep 13 '18 at 14:08
2

Really they should be checking to make sure `informacija` has a length of 3 as well. – juharr Sep 13 '18 at 14:09
I need: Lukas Velicka 20.50 Almeda Norkute 25.70 – Lukas Velička Sep 13 '18 at 14:10
Have a look at my edit. You were using the wrong index in your 'Console.WriteLine' call, too. – Mighty Badaboom Sep 13 '18 at 14:11
Single-Space separated CSV-like format isn't really the best of ideas to store data. Consider using actual csv, XML or JSON. That would be my advice. It will save you from headaches if you ever need to add information. @LukasVelička – Fildor Sep 13 '18 at 14:12
@Fildor The whole file format is not really good but that was not the question and maybe he can't change it. He does not need the count of the entries in the file, too (just another example). – Mighty Badaboom Sep 13 '18 at 14:13
@LukasVelička If it solved it then why does is not have a check mark? – paparazzo Sep 13 '18 at 14:15
@MightyBadaboom That's why I wrote a comment and "That would be my advice." – Fildor Sep 13 '18 at 14:15
@Fildor Ok, good point. – Mighty Badaboom Sep 13 '18 at 14:16
@paparazzo isn't there a min time that has to pass before you can accept any answer? I thought so ... (at least for rep 1 users) – Fildor Sep 13 '18 at 14:17
1

@Fildor 15 Minutes as far as I know – Mighty Badaboom Sep 13 '18 at 14:25

score 0 · Answer 2 · answered Sep 13 '18 at 14:13

Instead of informacija[i], informacija[i+1] and informacija[i+2], use informacija[0],informacija[1] and informacija[2] respectively.

And also use index i in console.writeline statement.

for (int i = 0; i < nariuKiekis; i++)
            {
                info[i] = failas.ReadLine();
                string[] informacija = info[i].Split(' ');
                narys[i].vardas = informacija[0];
                narys[i].pavarde = informacija[1];
                narys[i].pinigai = double.Parse(informacija[2]);
                Console.WriteLine("{0} {1} {2}", narys[i].vardas, narys[i].pavarde, narys[i].pinigai);
            }

Index was outside the bounds of the array. How to solve this problem?

2 Answers2