How change href value after window loading

Question

here is a a link with text:

<a id="linkk" href="/allgemeinen/sfsdf-sd-d-d-fd/"><p class="posttt">blablabla</p></a>

I want to delete nlinked after window loadend, here is js code:

    <script>
 window.onload = function() {
  var aEl = document.getElementById('linkk');
  aEl[0].href = "javascript:void(0)";
 };
 </script>

here is a example: https://geburtstagsplanet.com/allgemeinen/sfsdf-sd-d-d-fd/

but it doesn't work, why?

no, but when you use an id you can only change 1 element and you don't get an array returned, so ´elById.href` vs `elByClass[i].href`, `var els = document.getElementsByClassName('linkk'); for (var i = 0; i < els.length; i++) els.item(i).removeAttribute('href');` works for your page as it is for me. (see https://stackoverflow.com/questions/15843581/how-to-correctly-iterate-through-getelementsbyclassname - a `for in` loop fails) — zapl, Sep 14 '18 at 19:01

score 0 · Answer 1 · answered Sep 14 '18 at 18:16

0

<srcipt>
 window.onload = function() {
  var aEl = document.getElementsByClassName('linkk');
  aEl[0].href = "javascript:void(0)";
 };
 </script>

or

<srcipt>
 window.onload = function() {
  var aEl = document.getElementsByClassName('linkk');
  aEl[0].removeAttribute('href');
};
</script>

answered Sep 14 '18 at 18:16

Arun Kumar

885
5
11

not working: https://geburtstagsplanet.com/allgemeinen/sfsdf-sd-d-d-fd/ – Interessante Fakten Sep 14 '18 at 18:17
see my page: https://geburtstagsplanet.com/allgemeinen/sfsdf-sd-d-d-fd/ – Interessante Fakten Sep 14 '18 at 18:29

score 0 · Answer 2 · answered Sep 14 '18 at 18:19

0

document.getElementsByClassName() returns a collection of elements. You probably need to refer to a specific element in the collection. So

aEl.href

should actually be

aEl[0].href

answered Sep 14 '18 at 18:19

Daniel

1
3

While your answer seems being technically correct it never mentions how to use the case like in the question with `aEl = document.getElementById('linkk')` correct. You might want to add that to your answer. – David Sep 14 '18 at 18:36

Justin Pearce · Answer 3 · 2018-09-14T18:30:38.113

0

Firstly, your open script tag is misspelled. Should be <script> not <srcipt>

Secondly, getElementsByClassName returns an array. If you are trying to do this operation for all links, you need to iterate over the result:

<script>
window.onload = function() {
    var aEl = document.getElementsByClassName('linkk');
    for(var link in aEl) {
        link.href = "javascript:void(0)";
    }
};
</script>

Also, if you are using getElementsByClassName, you should update your HTML accordingly:

<a class="linkk" href="/allgemeinen/sfsdf-sd-d-d-fd/"><p class="posttt">blablabla</p></a>

edited Sep 14 '18 at 18:30

answered Sep 14 '18 at 18:23

Justin Pearce

4,994
2
24
37

@InteressanteFakten Your HTML has `linkk` as an id and not a class. – Justin Pearce Sep 14 '18 at 18:28
yes but i also updateds your code, please see source doe of my page – Interessante Fakten Sep 14 '18 at 18:31
can u please check? – Interessante Fakten Sep 14 '18 at 18:34
@InteressanteFakten If you look at your browser console, you might notice there are numerous javascript errors. These are probably preventing the `window.onload` method from firing. I suggest you address those before continuing. – Justin Pearce Sep 14 '18 at 18:42
@InteressanteFakten You need to look the errors in your browser console (Press F12, in most browsers) while on your site and try to fix the errors that are there. These are things beyond the code you are asking about. – Justin Pearce Sep 14 '18 at 19:21

score 0 · Answer 4 · answered Sep 14 '18 at 19:11

0

Below code should work.

<script>
    window.onload = function() {
        const elem = document.getElementsByClassName('linkk');

        for( let i = 0; i < elem.length; i++ ){
            elem[i].href = '#';
        }
    }
</script>

answered Sep 14 '18 at 19:11

Adarsh Somasundar

66
3

How change href value after window loading

4 Answers4