Javascript function not working in onSubmit for IE... getting no errors in Firefox

Question

function validateRequiredFields(formid) {

    var inputs = document.getElementsByClassName('required');

    for(i=0;i<inputs.length;i++) {

        var FieldID = inputs[i].id;

        if( document.getElementById( FieldID ).value == '' ) {

           document.getElementById( FieldID ).style.border = '2px solid #FA3811';
           document.getElementById( FieldID ).style.background = '#FAA08E';
           document.getElementById( FieldID ).focus();
           return false;

        }

    }

    return true;
   }

Any help is appreciated

What actually not works? Function not calls? Have you tried to put alert() at the first line of validateRequiredFields method? — CoolEsh, Mar 09 '11 at 12:28
The function is not actually firing in IE at all. I tried alerts — ThinkNewDev, Mar 09 '11 at 12:46
How are you calling the `validateRequiredFields` function? There is no indication in the code provided. — johnhunter, Mar 09 '11 at 12:54
onSubmit="return validateRequiredFields('form=$form['id']?>')" — ThinkNewDev, Mar 09 '11 at 12:56
You know that `inputs[i] == document.getElementById( FieldID )` ? You are overly complicating things. — Felix Kling, Mar 09 '11 at 13:11

score 3 · Accepted Answer · answered Mar 09 '11 at 12:26

3

The getElementsByClassName method is new in Firefox 3 and Safari 3.1, it doesn't exist in Internet Explorer, not even in version 9 beta.

answered Mar 09 '11 at 12:26

Guffa

687,336
108
737
1,005

+1 for spotting the unsupported method. Consider @burak's suggestion of using [jQuery](http://docs.jquery.com/Downloading_jQuery). – johnhunter Mar 09 '11 at 12:32
I reverted back to a older method using get elements by tag name. However I am now testing with an empty function with only an alert and I still get nothing in IE – ThinkNewDev Mar 09 '11 at 12:52
@Adam Coburn: post your updated code. – Felix Kling Mar 09 '11 at 13:25

score -1 · Answer 2 · answered Mar 09 '11 at 12:28

-1

i would consider using jQuery

var inputs = $('.required',document);

I think this could also solve your cross browser compatibility problem as well.

answered Mar 09 '11 at 12:28

pencilCake

51,323
85
226
363

Javascript function not working in onSubmit for IE... getting no errors in Firefox

2 Answers2