Is this (isset() && !empty()) function redundant?

Question

<?php
function isset_n_empty($var) {
    if (isset($var) && !empty($var)){
        return true;
    }
    return false;
}
echo isset_n_empty($x ?? null);

?>

my function is supposed to do the simple if (isset() && !empty()) logic and i used $x ?? null because if it is not used it would give me this error for undefined variables as the example

E_NOTICE : type 8 -- Undefined variable: x -- at line z

is it redundant or well-optimized?

Also you can write it shortly like `return isset($var) && !empty($var);` — Yang, Sep 22 '18 at 14:57
@Yang How does `&$` affects the function becasue i can't find an explaination about it? — Mark Elvis, Sep 22 '18 at 15:00

Stratadox · Accepted Answer · 2018-09-22T15:02:59.557

0

A variable that isn't set is considered empty by empty().

Therefore, if the variable is not set, it is also empty.

Your code could be shortened by using:

echo !empty($x);

I suppose that makes the answer to your question yes.

edited Sep 22 '18 at 15:02

answered Sep 22 '18 at 15:00

Stratadox

1,291
8
21

your example would not yield the same result - which is to tell if a variable both set and falsey. – But those new buttons though.. Sep 22 '18 at 15:02
That would be the case if the question was about `isset($x) && empty($x)`. – Stratadox Sep 22 '18 at 15:04
`!empty($x)` tells you that x is set and not empty which is not that same as *set and empty*. – But those new buttons though.. Sep 22 '18 at 15:10

score 0 · Answer 2 · answered Sep 22 '18 at 15:04

0

yes, the isset is redundant. if it's !empty(), then isset() always returns true.

answered Sep 22 '18 at 15:04

hanshenrik

19,904
4
43
89

score 0 · Answer 3 · answered Sep 22 '18 at 15:08

No the function is not redundant. It tells you if your variable is set but also falsey. There's nothing wrong with it.

On the other hand it seems like something that shouldn't really require a function of it's own. Instead of:

echo isset_n_empty($x ?? null);

You can just do:

echo isset($x) && !$x;

It's less code and doesn't require a function.

score 0 · Answer 4 · answered Sep 22 '18 at 15:09

0

I hope this will help:

function isset_not_empty($var){
    if(!isset($var))
        return false;
    else
         return (!empty($var))

 }

answered Sep 22 '18 at 15:09

Waelio

59
1
9

Is this (isset() && !empty()) function redundant?

4 Answers4