java script if condition with multiple values

Question

I got a role from the back-end If it is equals to "admin" , "staff", "manager" it should go to the if part of the block. otherwise it should go to the else part of the block.

let role = "restaurant";

if(role === "admin" || "manager" || "staff"){
  console.log("IF PART")
  console.log(role)
}
else{
  console.log("ELSE PART")
}

In this scenario it comes to if part. What's wrong with my code?

`role === "admin" || role === "manager" || role === "staff"` — Jaromanda X, Sep 27 '18 at 04:23
your code is like writing `if((role === "admin") || "manager" || "staff")` ... so that's `if (false || truthy || truthy)` - `false || truthy` is `truthy` - therefore IF PART — Jaromanda X, Sep 27 '18 at 04:26
you could also `if (["admin", "manager", "staff"].includes(role))` — Jaromanda X, Sep 27 '18 at 04:28
this has been asked so may times, even the "duplicate" as been marked as a duplicate of two answers, one of which is a duplicate of a duplicate of a duplicate!! Guess the "search" function is hard to use — Jaromanda X, Sep 27 '18 at 04:33
@JaromandaX I think i am one short :P because there are two links in another duplicate question :D — Lokesh Pandey, Sep 27 '18 at 04:37
I usually choose duplicates that have duplicates to embarrass... I mean, so the duplicate can be more useful! — Ram, Sep 27 '18 at 04:40
@undefined right. I also find it interesting when a question is marked as duplicate because it takes us to another question and contains more contents like in this problem. If we keep digging that's interesting. — Lokesh Pandey, Sep 27 '18 at 04:42

score 1 · Answer 1 · answered Sep 27 '18 at 04:26

1

Your if condition is wrong. This should be like

let role = "restaurant";

if(role === "admin" || role === "manager" || role === "staff"){
  console.log("IF PART")
  console.log(role)
}
else{
  console.log("ELSE PART")
}

answered Sep 27 '18 at 04:26

Lokesh Pandey

1,739
23
50

Pardeep Dhingra · Accepted Answer · 2018-09-27T04:34:55.180

Your if condition is wrong, you are suppose to compare role variable with the role you want to check. As @lokesh mentioned in his code.

(role === "admin" || role === "manager" || role === "staff")

Another way of doing this:

let role = "restaurant";
    
if(["admin", "manager", "staff"].includes(role)){
  console.log("IF PART")
  console.log(role)
}
else{
  console.log("ELSE PART")
}

includes available in majority of browsers for IE you can use indexOf.

score 1 · Answer 3 · edited Sep 27 '18 at 05:07

1

I think, you can do more accurately as follows

let role = "restaurant";

if (["admin", "manager", "staff"].indexOf(role.toLowerCase()) >= 0) {
  console.log("IF PART")
  console.log(role)
} else {
  console.log("ELSE PART")
}

edited Sep 27 '18 at 05:07

Lokesh Pandey

1,739
23
50

answered Sep 27 '18 at 04:29

Azad

5,144
4
28
56

java script if condition with multiple values

3 Answers3