i want to change the image when i click on a check box

Question

I want that when I click first time on this check box it should change the image from my Image View and when I click again on same checkbox it should change the image in Image View with another Image.

I Tried:-

checkbox.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
    @Override
    public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
         if(isChecked){
             myImage.setBackgroundResource(R.drawable.saveimage);
         }else{
             myImage.setBackgroundResource(R.drawable.deleteimage);
         }
     }
 });

CHECK https://stackoverflow.com/questions/33942116/state-checked-doesnt-toggle-imageview-on-and-off/34020870#34020870 — Chirag Savsani, Sep 27 '18 at 11:40
@Michael Dodd and Rohit5k2 it's not showing any error, when i select checkbox first time it' set a image in my image view but when i click on it again it's not doing anything — Amit Sharma, Sep 27 '18 at 11:45
Check these link https://stackoverflow.com/questions/21850354/toggle-image-in-imageview-on-double-tap https://stackoverflow.com/questions/4193167/change-source-image-for-image-view-when-pressed/22476407 — Diptendu Das, Sep 27 '18 at 11:48
@Chirag Savsani thank you so much, it's done thanks for your help. — Amit Sharma, Sep 27 '18 at 12:00

Amit Sharma · Accepted Answer · 2018-09-28T08:40:30.503

1

It's done:-

Take globally (boolean switchStatus = false);

if(switchStatus == true){
    dialog.dismiss();
    image1.setImageResource(R.drawable.icon_delete);
    switchStatus = false;
}else{
    dialog.dismiss();
    image1.setImageResource(R.drawable.icon_checkmark);
    switchStatus = true;
}

edited Sep 28 '18 at 08:40

answered Sep 27 '18 at 12:03

Amit Sharma

261
1
4
20

This code can be simplified. Use `if (switchStatus) {`, and after the end of the `if/else` statement use `switchStatus = !switchStatus` to flip its value instead of manually setting to `true` or `false`. Would you like me to edit your answer with this simplification? – Michael Dodd Sep 27 '18 at 12:34
(Truth be told this can also be reduced to just 3 lines of code using a [ternary operator](https://en.wikipedia.org/wiki/Ternary_operation), but that might be a bit too advanced for the scope of this question) – Michael Dodd Sep 27 '18 at 12:38

score 0 · Answer 2 · answered Sep 27 '18 at 11:49

0

There is nothing wrong with your code apart from the lack of using setchecked method. When you check your chechbox , call checkbox.setchecked(true) and when you unckeck it, call checkbox.setchecked(false);

answered Sep 27 '18 at 11:49

Sotiris S. Magionas

759
6
25

score 0 · Answer 3 · answered Sep 27 '18 at 11:50

Because your image is in Drawable I think you should try this:

checkbox.setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
    @Override
    public void onCheckedChanged(CompoundButton buttonView, boolean isChecked) {
         if(isChecked){
             myImage.setImageDrawable(getResources().getDrawable(R.drawable.saveimage,getApplicationContext().getTheme()));
         }else{
             myImage.setImageDrawable(getResources().getDrawable((R.drawable.deleteimage,getApplicationContext().getTheme()));
         }
     }
 });

i want to change the image when i click on a check box

3 Answers3